Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console not live updating in staging after first module deployment #435

Closed
alecthomas opened this issue Oct 4, 2023 · 1 comment · Fixed by #478
Closed

Console not live updating in staging after first module deployment #435

alecthomas opened this issue Oct 4, 2023 · 1 comment · Fixed by #478
Assignees
Labels
bug Something isn't working

Comments

@alecthomas
Copy link
Collaborator

alecthomas commented Oct 4, 2023

I deployed the online-boutique, and the first module rolled out and was visible in the console, but subsequent modules wouldn't update the console without a full refresh.

One difference to ftl-dev, beyond the obvious, is that it has two controllers. There could be some issue where one controller is receiving the commands and the other isn't getting updates. Though that said, the CLI issues a whole bunch of requests, so I would expect 50% of them to hit each controller.

Strangely, ftl call events/logs do show up.

@alecthomas alecthomas added the bug Something isn't working label Oct 4, 2023
@alecthomas alecthomas added this to FTL Oct 4, 2023
@alecthomas alecthomas moved this to In Progress in FTL Oct 4, 2023
@wesbillman
Copy link
Collaborator

This is an interesting issue and I'm not 💯 on what the best approach is. That Timeline component sets the filters the first time to include all modules if none are currently selected in the filter. The idea here is that it will show all current modules by default when it runs. However, if modules are coming online at different times, I'm not sure what the filter should show. Ideally, it would be all modules if nothing has been selected.

We might have to add a flag like user_has_changed_modules or something so we know if we should include all modules or not during start up. Very open to other ideas here as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants