Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log All modules deployed after rebuilds #1706

Closed
deniseli opened this issue Jun 7, 2024 · 0 comments · Fixed by #1778
Closed

Log All modules deployed after rebuilds #1706

deniseli opened this issue Jun 7, 2024 · 0 comments · Fixed by #1778
Assignees
@matt2e
Labels
good first issue Good for newcomers

Comments

@deniseli
Copy link
Contributor

deniseli commented Jun 7, 2024

From @jiyoontbd

Feature request: after a hot-reload, would it be terribly difficult to show the same message at the end info: All modules deployed, watching for changes... like what I see when I first boot up pfi by typing just dev? After a hot reload, I’m not always sure it’s done redeploying and it’s ok to proceed with more changes.
@deniseli deniseli added the good first issue Good for newcomers label Jun 7, 2024
@github-actions github-actions bot added the triage Issue needs triaging label Jun 7, 2024
@ftl-robot ftl-robot mentioned this issue Jun 7, 2024
Open
@alecthomas alecthomas added next Work that will be be picked up next and removed triage Issue needs triaging labels Jun 10, 2024
@gak gak mentioned this issue Jun 10, 2024
Closed
@matt2e matt2e self-assigned this Jun 14, 2024
@github-actions github-actions bot removed the next Work that will be be picked up next label Jun 14, 2024
@matt2e matt2e mentioned this issue Jun 14, 2024
Merged
matt2e added a commit that referenced this issue Jun 14, 2024
@matt2e
fix: ftl dev notifies when all deployments are up to date (#1778)
c312807 
fixes #1706
when both of these things happen:
- we update a deployment successfully
- the engine idles for long enough for the file watcher to do 2 cycles
then we log "All modules deployed, watching for changes..."
@gak gak mentioned this issue Jun 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matt2e matt2e

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ftl dev notifies when all deployments are up to date block/ftl
3 participants
@alecthomas @matt2e @deniseli