-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop the requirement to set a provider when setting config/secrets through the controller and there's only one provider #1701
Comments
@alecthomas I am not clear on "Instead the cluster would be required to start with a flag specifying the writing resolve, so the client would not make any decisions." - my best guess is... The cluster needs to expose a flag to determine which config / secret provider to use as default, in the event that there are multiple, so the client is never required to supply a provider when setting a config or secret. Is that anywhere near what you meant? |
That's exactly correct. Instead of the client controlling what writer to use, the controller does. |
This is not high priority though, let me remove it from next. |
Actually let's do some prioritisation in the sync today. |
@jonathanj-square I'm going to include this in some general config refactoring I'm doing |
eg. in production there's (currently) only ASM/DB, so it's redundant to have to specify
--asm
Instead the cluster would be required to start with a flag specifying the writing resolve, so the client would not make any decisions.
This change should allow the controller to support multiple providers for reading but only one for writing, as usual, but the controller is the one that selects the writer at startup. This would also remove the types for setting the provider over gRPC. The client will still need these flags for the local case, but for the gRPC path it would be able to skip requiring the user to set a writer.
The text was updated successfully, but these errors were encountered: