Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we remove the /ingress from the path from http ingress request #1609

Closed
wesbillman opened this issue May 30, 2024 · 2 comments · Fixed by #1615
Closed

Can we remove the /ingress from the path from http ingress request #1609

wesbillman opened this issue May 30, 2024 · 2 comments · Fixed by #1615
Assignees
@wesbillman

Comments

@wesbillman
Copy link
Collaborator

For local development when coding against pre defined specifications, this can make things a bit more difficult.

Also, would it be stripped when running in a production environment?
@github-actions github-actions bot added the triage Issue needs triaging label May 30, 2024
@ftl-robot ftl-robot mentioned this issue May 30, 2024
Open
@alecthomas
Copy link
Collaborator

We're currently hosting the gRPC servers and the ingress on the same port, so we can't host them on /. That said, it's probably safer and cleaner to just put ingress on a separate port and HTTP server, which would solve this problem as well.

@wesbillman
Copy link
Collaborator Author

Oh nice yea! that might help with some of the security controls as well so they could have different roles for the ingress port vs. others

@wesbillman wesbillman self-assigned this May 31, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label May 31, 2024
@wesbillman wesbillman mentioned this issue May 31, 2024
Merged
wesbillman added a commit that referenced this issue Jun 1, 2024
@wesbillman
feat: use separate bind for http ingress server (#1615)
f445e18 
Fixes #1609 

@alecthomas I took a stab at this one. Lemme know if there's a better
approach here. :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wesbillman wesbillman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use separate bind for http ingress server block/ftl
2 participants
@alecthomas @wesbillman