Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use FTL secrets for DSNs as an intermediate step #1427

Closed
alecthomas opened this issue May 7, 2024 · 0 comments · Fixed by #1483
Closed

Use FTL secrets for DSNs as an intermediate step #1427

alecthomas opened this issue May 7, 2024 · 0 comments · Fixed by #1483
Assignees
@deniseli

Comments

@alecthomas
Copy link
Collaborator

Rather than relying on environment variables we should use FTL secrets. This will make launching into production simpler and safer, as each module will only get the DSNs it actually needs, rather than all DSNs via envars.
@github-actions github-actions bot added the triage Issue needs triaging label May 7, 2024
@alecthomas alecthomas mentioned this issue May 7, 2024
Open
@matt2e matt2e added next Work that will be be picked up next and removed triage Issue needs triaging labels May 8, 2024
@deniseli deniseli self-assigned this May 8, 2024
@github-actions github-actions bot removed the next Work that will be be picked up next label May 8, 2024
@deniseli deniseli mentioned this issue May 14, 2024
Merged
deniseli added a commit that referenced this issue May 14, 2024
@deniseli
feat: use secrets instead of env vars for DSNs (#1483)
c3c7077 
Fixes #1427

database/ftl-project.toml was written using:
```
ftl secret set --inline database.FTL_DSN_DATABASE_TESTDB --config integration/testdata/go/database/ftl-project.toml
```

This PR only works thanks to this earlier PR:
#1472
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deniseli deniseli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use secrets instead of env vars for DSNs block/ftl
3 participants
@alecthomas @matt2e @deniseli