Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor how the internal scheduled tasks set their timeouts #1381

Closed
alecthomas opened this issue May 2, 2024 · 0 comments · Fixed by #1465
Closed

Refactor how the internal scheduled tasks set their timeouts #1381

alecthomas opened this issue May 2, 2024 · 0 comments · Fixed by #1465
Labels
good first issue Good for newcomers

Comments

@alecthomas
Copy link
Collaborator

Currently each scheduled task returns a duration which determines when the task will run next. This is flexible, but in practice we never use this, always returning a single value. It also prevents us from easily having separate schedules for production and development, and a production schedule is rarely convenient for development, where we favour responsiveness.

We should remove the ability of tasks to return their own schedule, and instead specify the duration when they're scheduled.

@alecthomas alecthomas added the good first issue Good for newcomers label May 2, 2024
@github-actions github-actions bot added the triage Issue needs triaging label May 2, 2024
@alecthomas alecthomas mentioned this issue May 2, 2024
@worstell worstell removed the triage Issue needs triaging label May 2, 2024
alecthomas added a commit that referenced this issue May 11, 2024
There are two changes that contribute to this improvement:

1. Reduce most task reschedule timers to 1s.
2. Decrease runner/controller heartbeats to 1s.
3. Clear all transient database rows that slow down restarts - leases,
   runner/controller locks, etc.

Fixes #1010
Fixes #1381
alecthomas added a commit that referenced this issue May 11, 2024
There are two changes that contribute to this improvement:

1. Reduce most task reschedule timers to 1s.
2. Decrease runner/controller heartbeats to 1s.
3. Clear all transient database rows that slow down restarts - leases,
   runner/controller locks, etc.

Fixes #1010
Fixes #1381
alecthomas added a commit that referenced this issue May 11, 2024
There are two changes that contribute to this improvement:

1. Reduce most task reschedule timers to 1s.
2. Decrease runner/controller heartbeats to 1s.
3. Clear all transient database rows that slow down restarts - leases,
   runner/controller locks, etc.

Fixes #1010
Fixes #1381
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants