Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CBOR constructor/alternative support from cbor.Value to generic encoder/decoder #550

Open
agaffney opened this issue Mar 17, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@agaffney
Copy link
Contributor

agaffney commented Mar 17, 2024

This is trickier than the simple types since there are multiple ranges of tag numbers that map to constructor indexes. We can probably get rid of cbor.Value all together after this, but we'll probably want to keep cbor.LazyValue, or at least its deferred parsing ability.

There doesn't seem to be a way to use TagSet.Add() in a way that allows using multiple tag numbers with a single object type while being able to preserve the original tag number. This doesn't leave us with many options, and probably not any good ones.

@agaffney agaffney assigned agaffney and unassigned agaffney Mar 17, 2024
@agaffney
Copy link
Contributor Author

I created the upstream issue fxamacker/cbor#508 for this

agaffney added a commit that referenced this issue Mar 26, 2024
@wolf31o2 wolf31o2 added the enhancement New feature or request label Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants