fixed error handling

blhsing · Jul 5, 2024 · 40f7c35 · 40f7c35
1 parent 4e1af59
commit 40f7c35
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 4 deletions.
diff --git a/Objects/frameobject.c b/Objects/frameobject.c
@@ -2106,11 +2106,13 @@ PyObject*
 _PyEval_BuiltinsFromGlobals(PyThreadState *tstate, PyObject *globals)
 {
     PyObject *builtins;
-    int has_builtins = PyMapping_GetOptionalItem(globals, &_Py_ID(__builtins__), &builtins);
+    int has_builtins = PyMapping_GetOptionalItem(
+        globals, &_Py_ID(__builtins__), &builtins);
     if (has_builtins < 0) {
         return NULL;
     }
     if (has_builtins) {
+        /* release reference right away since we mean to only borrow it */
         Py_DECREF(builtins);
         if (PyModule_Check(builtins)) {
             builtins = _PyModule_GetDict(builtins);

diff --git a/Python/bytecodes.c b/Python/bytecodes.c
@@ -1476,7 +1476,8 @@ dummy_func(
             int err = PyMapping_DelItem(GLOBALS(), name);
             // Can't use ERROR_IF here.
             if (err < 0) {
-                if (PyErr_ExceptionMatches(PyExc_KeyError)) {
+                if (_PyErr_Occurred(tstate) &&
+                    _PyErr_ExceptionMatches(tstate, PyExc_KeyError)) {
                     _PyEval_FormatExcCheckArg(tstate, PyExc_NameError,
                                               NAME_ERROR_MSG, name);
                 }

diff --git a/Python/executor_cases.c.h b/Python/executor_cases.c.h
diff --git a/Python/generated_cases.c.h b/Python/generated_cases.c.h