Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the docker #494

Merged
merged 7 commits into from
Mar 8, 2017
Merged

Add the docker #494

merged 7 commits into from
Mar 8, 2017

Conversation

SnowMasaya
Copy link
Contributor

I made a dockerfile for edward.

Reference

http://edwardlib.org/troubleshooting

for using the every environment
@dustinvtran
Copy link
Member

Cool! Do you know how this can be checked? (I've never used Docker.)

@pwl
Copy link

pwl commented Mar 2, 2017

I can confirm that this works flawlessly with my setup (Arch Linux and nvidia graphics card with nvidia-docker installed).

Would it be possible to have an option to install the CPU version of TF instead of the GPU?

@SnowMasaya
Copy link
Contributor Author

SnowMasaya commented Mar 2, 2017

@dustinvtran

When you check the it works well, you below the type command.(you move to the docker directory)

build check

make build-gpu

test check in the docker environment(GPU)

make test-gpu

@pwl

OK.
I will add the CPU version

for gpu environment
for gpu environment
for specify the gpu environment
for specify the gpu environment
for gpu environment
@SnowMasaya
Copy link
Contributor Author

SnowMasaya commented Mar 2, 2017

I added the Docker file for CPU version.

If you use the it, you read the README.md

I wrote the how to use the Docker for CPU environment and GPU environment

@pwl
Copy link

pwl commented Mar 3, 2017

Thanks for the changes! Out of curiosity, what is the reason to run jupyter notebook command in the Dockerfile instead of in the Makefile?

@SnowMasaya
Copy link
Contributor Author

SnowMasaya commented Mar 4, 2017

@pwl

what is the reason to run jupyter notebook command in the Dockerfile instead of in the Makefile?

I think the most of the people would like to use "edward" in the notebook.

That is reason why the default command set the "jupyter notebook"

@dustinvtran
Copy link
Member

@SnowMasaya | Thanks again for this. Is there anything this is still waiting on? (@pwl can act as the code reviewer instead of me. :-)

@pwl
Copy link

pwl commented Mar 8, 2017

I can verify that both containers (CPU and GPU) work, I'd merge this.

@dustinvtran dustinvtran merged commit b52030b into blei-lab:master Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants