Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Token in env-variable #20

Merged
merged 12 commits into from
Mar 28, 2023
Merged

API Token in env-variable #20

merged 12 commits into from
Mar 28, 2023

Conversation

Weidav
Copy link
Contributor

@Weidav Weidav commented Mar 27, 2023

  • Added the possibility to store the API-Token in an environmental-variable.
  • Added the description on how to do it to the readme/documentation
  • fixed some typos and dead links

solves this Issue: #13

@blaylockbk blaylockbk merged commit 17364a3 into blaylockbk:main Mar 28, 2023
@blaylockbk
Copy link
Owner

Thanks @Weidav for putting this together. I like the added option to have the token as an env variable. And thanks for fixing the links, spelling, etc. It's much appreciated.

@Weidav
Copy link
Contributor Author

Weidav commented Mar 29, 2023

Thanks for the quick merge!

Do you plan to release this or a future version on PyPI?

@blaylockbk
Copy link
Owner

Done. https://pypi.org/project/SynopticPy/

Thanks for the poke.

I am also working on a conda-forge recipe. conda-forge/staged-recipes#22414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants