#76 : edit forms #83
#76 : edit forms #83
Conversation
| Cards = apps.get_model("cards", "Card") | ||
| for card in Cards.objects.all(): | ||
| new_value = card.help_links | ||
| if '\n' in new_value: |
There was a problem hiding this comment.
new_values.splitlines() should work. No?
There was a problem hiding this comment.
Didn't know about this method and you are right!
| @@ -0,0 +1,28 @@ | |||
| # -*- coding: utf-8 -*- | |||
| # Generated by Django 1.11.4 on 2018-03-30 09:42 | |||
There was a problem hiding this comment.
I think this is not true anymore, right?
There was a problem hiding this comment.
About? Version of Django?
When you create a custom migration, it's easier to create an empty one and edit it.
There was a problem hiding this comment.
The biggest part of the file is not django generated anymore so you can drop the comment saying it's django code.
There was a problem hiding this comment.
Yeah, right but who reads comments nowaday?! :-°
| new_value = new_value.split('\n') | ||
| else: | ||
| new_value = list(new_value) | ||
| card.help_links = str(new_value) |
There was a problem hiding this comment.
I don't understand why you cast it back to str.
src/cards/models.py
Outdated
| default='ACTIVE') | ||
| year = models.SmallIntegerField() | ||
| waste_reduction = models.DecimalField(decimal_places=1, max_digits=6, | ||
| blank=True, null=True) |
There was a problem hiding this comment.
Could you align on opened parenthesis?
| @@ -31,6 +31,10 @@ class Meta: | |||
| class CardSerializer(serializers.ModelSerializer): | |||
| card_stats = CardStatSerializer() | |||
| slug = serializers.CharField(required=False) | |||
| help_links = serializers.ListField( | |||
There was a problem hiding this comment.
The doc specify that that you should not invoke it directly but use serializers.CharField(many=True) instead.
Any reason you didn't?
There was a problem hiding this comment.
Hmmm I'd like to know about the doc saying that?
I just found that: http://www.django-rest-framework.org/api-guide/fields/#listfield
But I didn't find what you are talking about?
There was a problem hiding this comment.
| gender: get(this.props, 'user_data.gender'), | ||
| }; | ||
| userFields = editUserFields; | ||
| btnText = 'Edit User!'; |
| let userForm; | ||
| let initialData = {}; | ||
| let userFields = createUserFields; | ||
| let btnText = 'Create user!'; |
src/static/containers/ZeroCard.jsx
Outdated
| link: PropTypes.string, | ||
| status: PropTypes.string, | ||
| }), | ||
| co2_reduction: PropTypes.string, |
There was a problem hiding this comment.
Why string? We should send numbers here.
There was a problem hiding this comment.
encode/django-rest-framework#508
Changed the settings of REST_FRAMEWORK not to send string instead of decimal
src/static/utils/generateForm.jsx
Outdated
| if (splitArray[0] in initialData) { | ||
| let init = initialData[splitArray[0]]; | ||
| for (let data of splitArray.slice(1)) { | ||
| init = init[data]; |
There was a problem hiding this comment.
This piece seems either buggy either too much complicate for what it aims to do… What's the purpose of this?
There was a problem hiding this comment.
Getting the initialData from the object we get:
{ card_stats: { waste_reduction: 1, ... }, }
with the id field like "card_stats.waste_reduction"
There was a problem hiding this comment.
Could get from lodash do the job? It tipically can do this: get(object, "card_stats.waste_reduction", defaultValue)
src/static/utils/generateForm.jsx
Outdated
| onClick={onCancel} | ||
| size="large" | ||
| > | ||
| Cancel |
| new_value = list(new_value) | ||
| card.help_links = str(new_value) | ||
| new_value = card.help_links.splitlines() | ||
| card.help_links = new_value |
There was a problem hiding this comment.
The use of new_value is not necessary anymore
Be careful with the custom migration.
Worked with me but I do not know if there was another type before a plain text separated by \n for help_links...