Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should data be read from sqlite? #7

Closed
blalop opened this issue Aug 19, 2022 · 0 comments
Closed

Should data be read from sqlite? #7

blalop opened this issue Aug 19, 2022 · 0 comments
Labels
question Further information is requested

Comments

@blalop
Copy link
Owner

blalop commented Aug 19, 2022

Currently, the input data comes directly from the documents the bank provides: built-in bbva2pandas reads this documents and generates a dataframe on demand.

This approach generates some issues:

  • All documents must be available to the app
  • bbva2pandas pip dependency
  • time spent in bbva2pandas parsing

bbva2pandas allow the exported data to be exported in sqlite format. This app could use that format and use SQL queries directly to retrieve the data, rendering the app simpler.

@blalop blalop added the question Further information is requested label Aug 19, 2022
blalop added a commit that referenced this issue Aug 19, 2022
blalop added a commit that referenced this issue Aug 19, 2022
blalop added a commit that referenced this issue Aug 19, 2022
#7 read data from sqlite, removed bbva2pandas direct dependency
@blalop blalop closed this as completed Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant