Fix HA IP address and WebRTC port inferring #5209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for frigate-docs canceled.
|
NickM-27
approved these changes
Jan 23, 2023
blakeblackshear
approved these changes
Jan 24, 2023
|
@felipecrs this change has broken go2rtc for non addon users. You are calling |
|
Sorry I did not catch it during review |
|
Oh no! That's my bad! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that I upgraded my own Frigate instance I got to test this more, and for some reason the regex worked in my previous test but didn't work in the Frigate container. This fixes it.
Also, I forgot the SSH port there instead of the WebRTC port because I was testing against the Terminal add-on.