Show All and Solo selection buttons for MultiSelect. #4723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to previous behavior of viewing events for single camera with 1 click, or All. * Fix visual bug with MultiSelect when selecting similar named options. eg. options like frontdoor, frontside, backdoor, etc
✅ Deploy Preview for frigate-docs canceled.
|
NickM-27
requested changes
Dec 17, 2022
* Change MultiSelect onSolo to onSelectSingle
* Different look for SelectSingle buttons * Show All button is aligned with the items below it, no matter the popup size
|
Looks good, did you have a chance to look at the button autofocus issue? I have a screen cap showing it: Screen.Recording.2022-12-17.at.11.13.24.AM.movI think the fix may be as simple as just setting |
NickM-27
approved these changes
Dec 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to previous behavior of viewing events for single camera with 1 click, or All.
& Fix visual bug with MultiSelect when selecting similar named options. eg. options like frontdoor, frontside, backdoor, etc
Looks like this:
nIlKqs7X1P.mp4