Support more special chars in camera passwords #4259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for frigate-docs canceled.
|
NateMeyer
changed the title
NateMeyer
changed the title
NateMeyer
changed the title
|
Looks like go2rtc still has an issue with this. |
What issue are you seeing with go2rtc? |
NickM-27
reviewed
Nov 5, 2022
I think we need to use the |
NickM-27
approved these changes
Nov 5, 2022
herostrat
pushed a commit
to herostrat/frigate
that referenced
this pull request
Nov 24, 2022
* Support more special chars in camera passwords * End password test with double @ chars * Escape passwords in paths for go2rtc * Fixes for formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #4257. Match all non-whitespace characters in password field. Need to explicitly match
://at the beginning so it isn't considered the user delimiter.