[pull] master from web-platform-tests:master #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Differential Revision: https://phabricator.services.mozilla.com/D224196 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1916977 gecko-commit: e90edd140de4427070c89c454e872f1a1034ea12 gecko-reviewers: webdriver-reviewers, jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D223304 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1920989 gecko-commit: 9b788d14998dee0c7ff23801251bc081eb0d0a96 gecko-reviewers: smaug, dom-storage-reviewers, janv, asuth
Differential Revision: https://phabricator.services.mozilla.com/D222656 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1918288 gecko-commit: ae9c76aad44aadbc41f3711e61c146c92defb381 gecko-reviewers: webdriver-reviewers, jdescottes
… for each test Using a new_tab context for each and every test in the file should avoid side effects between tests. Differential Revision: https://phabricator.services.mozilla.com/D224118 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1921767 gecko-commit: 0d6041f18ea1205cc0dbd9cb2fc54bb35ef66f44 gecko-reviewers: webdriver-reviewers, whimboo
...since on some configurations that's what actually provides the implementation. Most of the places where we included testdriver we don't actually use it [1] (so we could get away with missing -vendor), but it's likely we will need it everywhere, so I think I would rather fix it than remove it. [1] It's only used for deleteAllCookies for now. Change-Id: Icf8f8e9f18cd08ce06b775412ccb08aa9153fe58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5905378 Reviewed-by: mmenke <[email protected]> Commit-Queue: Maks Orlovich <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363024}
See w3c/csswg-drafts#10780 (comment) Bug: 369895168 Change-Id: I4c06f4c3fbf99f83f06390244a3d7d732c7ce287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5901995 Reviewed-by: Khushal Sagar <[email protected]> Reviewed-by: Vladimir Levin <[email protected]> Commit-Queue: Noam Rosenthal <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363033}
This change creates a new API method for TextMetrics objects in Canvas, that returns the specific ranged split into its minimal grapheme clusters, i.e. the smallest units that make sense to render separately from the perspective of the user. The returned object, named TextCluster, contains all the information needed for it to be rendered and shaped in the same way as in the input given to `ctx.measureText()`. This includes the begin and end indices on the input string, x and y positions relative to the anchor point of the Canvas context when the text is measured, and the complete text to preserve the context needed to reshape the text exactly the same. The final optional parameter for `getTextClustersForRange()` is dictionary to specify the desired anchor point position for each cluster. This enables the API to adjust the returned x and y positions to a different align/baseline that the ones used when the text was measured. The new API was enabled under the `ExtendedTextMetrics` flag. The next CL in the stack creates a new method for the Canvas rendering context that enables the rending of TextCluster objects. Bug: 341213359 Change-Id: Ie668ec4a266d4b5a99443125c7099e6f72714f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5839992 Reviewed-by: Koji Ishii <[email protected]> Commit-Queue: Andres Ricardo Perez <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363086}
The call to CheckLoaded() applies the restriction that the image must have completed loading before the overall check can be performed. This in turn means that callers ImageResourceContent::IsAccessAllowed() can only be safely do after the resource has finished loading. This clashes with all forms of progressive rendering of images. Drop the CheckLoaded() call since we've locked down the loading of subresources for SVGImage in a more thorough way since the check was added. This allows answering the security-origin query in a progressive way and avoids the crash in the referenced bug. Fixed: 366547215 Change-Id: I2adfe7b3406572f0e1b1a956ac6aa4bf50b19c5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5892795 Reviewed-by: Philip Rogers <[email protected]> Commit-Queue: Fredrik Söderquist <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363100}
When the stylable select picker is open, type to search should focus but not select an option until the selection is confirmed. Fixed: 362922565 Change-Id: Ib351c57266fd7bedb98ff5b1f2c72bea455b3778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5902298 Reviewed-by: Joey Arhar <[email protected]> Commit-Queue: Traian Captan <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363185}
…BlobEvent. spec, https://w3c.github.io/mediacapture-record/#dom-blobevent-timecode, said that the timecode is time delta from the first BlobEvent of this recorder. Here are issues and its discussion. w3c/mediacapture-record#222 w3c/mediacapture-record#223 Bug: 40247788 Change-Id: Ic9c74299230b9839578ca317fff056e7a1b26dc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5631009 Commit-Queue: Sunggook Chue <[email protected]> Reviewed-by: Markus Handell <[email protected]> Reviewed-by: Gabriel Brito <[email protected]> Cr-Commit-Position: refs/heads/main@{#1362716}
This pseudo class matches the presence of assigned nodes in the slot element. https://drafts.csswg.org/css-scoping-1/#the-has-slotted-pseudo Bug: 369883705 Change-Id: I7c848204d7c39860f39fab19290ef366e94d0a3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5899636 Reviewed-by: Joey Arhar <[email protected]> Reviewed-by: Luke <[email protected]> Auto-Submit: Keith Cirkel <[email protected]> Commit-Queue: Keith Cirkel <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363222}
With mediation optional, some tests may not show the account chooser which might affect certain functions in the tests. Bug: None Change-Id: Iaf53657f8b5a43c41157c721774ef828a1b7987f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5905460 Commit-Queue: Yi Gu <[email protected]> Reviewed-by: Christian Biesinger <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363235}
Previously https://chromium-review.googlesource.com/c/chromium/src/+/5895659 fixed a few tests to do it by hand, but I want to do use testdriver in a lot more tests (e.g. to do attestation), so it makes more sense to have subordinate-frame set things up for it correctly just like it does for our own messages. Change-Id: I48604d1c99678fcfedf41e446ef7e16546a4c3b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5905379 Reviewed-by: mmenke <[email protected]> Commit-Queue: Maks Orlovich <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363240}
Mixed bidi text runs are always challenging when it comes to PositionFromOffset and related methods, because a particular location where the direction changes is the start of two runs or the end of two runs. The choice of which index to return depends on what the offset is going to be used for. This CL changes caretPositionFromPoint to adjust the position returned when at the end of a text run that does not match the overall text direction. The position is moved to a neighboring run to match the behavior of the DOM method, which in this case is also probably better for building selection and insert behavior. Fixed: 364332944 Change-Id: I742f567cdf0e9a116d5d430d47d952a0f7c04301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5889819 Reviewed-by: Andres Ricardo Perez <[email protected]> Commit-Queue: Stephen Chenney <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363262}
https://chromium-review.googlesource.com/c/chromium/src/+/5749947 Did some changes to correctly call kContent & kIntrinsic within flex for the purposes of determining flex-basis. This uncovered a bug where we'd layout a flex-item (with an aspect-ratio, and a container-query container), and not correctly relayout when the size changed. This is the first part of the mitigation. E.g. when we have size containment we don't need to run layout to determine the intrinsic block-size. There is a set of other issues in this area. But this mitigates the regression for the moment. Bug: 370480725 Change-Id: I8301a424fca86392c2ec1a7cfcf867142e413b31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5901118 Commit-Queue: Ian Kilpatrick <[email protected]> Reviewed-by: David Grogan <[email protected]> Reviewed-by: David Baron <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363322}
Currently, document picture-in-picture windows use quirks mode by default, since they're just about:blank windows. This CL makes the pip document match the opener document's compatibility mode instead. WICG/document-picture-in-picture#128 https://groups.google.com/a/chromium.org/g/blink-dev/c/IR7qdNj4Zyw Bug: 370423046 Change-Id: Ib1a84947b2408ae0be236afc2173fbcb0f77b598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5900737 Reviewed-by: Frank Liberato <[email protected]> Commit-Queue: Tommy Steimel <[email protected]> Reviewed-by: Nate Chapin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363338}
Two tests were using await in a non-async function. And a test helper was using newAnonymousIframe which was updated at some point to newIframeCredentialless. Bug: 346991169 Change-Id: I4333b6abee03ed48cf0d10d3417a2c15fba06d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5906718 Commit-Queue: Nathan Memmott <[email protected]> Reviewed-by: Ayu Ishii <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363384}
This reverts commit fe27a7828eb3902d1b12c05fd97d4e7e13c8554b. Reason for revert: Suspect of causing test failures: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests/148853/ Original change's description: > FSA: Fix more manual WPTs > > Two tests were using await in a non-async function. And a test helper > was using newAnonymousIframe which was updated at some point to > newIframeCredentialless. > > Bug: 346991169 > Change-Id: I4333b6abee03ed48cf0d10d3417a2c15fba06d30 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5906718 > Commit-Queue: Nathan Memmott <[email protected]> > Reviewed-by: Ayu Ishii <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1363384} Bug: 346991169 Change-Id: Ie3a3b3fea9a3a2f3a735e082c30e74e3be59c3f2 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5906899 Auto-Submit: Luciano Pacheco <[email protected]> Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Owners-Override: Luciano Pacheco <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363433}
…ayed According to the spec[1], the `<object>` element that is not rendered will not fetch request. > if the element is not being rendered, then jump to the step below > labeled fallback. > Fallback: The object element represents the element's children. In the `object-in-object-fallback-2.html` test case, all `<object>` elements are not being displayed, so no elements should be loaded. Remove `display: none` in this test case to test the `<object>` element nesting inside the `<object>` element. Revise the `object-in-display-none-load-event.html` test case to ensure that the `object` element is not loaded. Bug: 40781343 Change-Id: I190c937dbe643f5d1502529f8a530687ed8fcb9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5904314 Reviewed-by: Mason Freed <[email protected]> Reviewed-by: Traian Captan <[email protected]> Commit-Queue: Peng Zhou <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363461}
…d intermittent failures on slow configurations. Before this change, some pieces of this test intermittently timed out or failed to run, in the more-heavyweight Firefox configurations (e.g. TSAN/ASAN, particularly with debugging enabled). These failures seem to be because the animation/transition durations in this test were too short, such that the animation/transition occasionally complete on their own before the test is ready for them to complete (i.e. before the test explicitly advances to the end of an animation by programmatically setting 'currentTime'). I can reproduce similar failures in release Firefox and Chrome builds if I simply reduce the animation/transition durations (from 1s to 0.1s), so I think these failures are an indication of a race condition in the test logic (a fragile dependency on the animation taking "long enough" that it won't complete on its own), rather than a browser bug. This patch attempts to avoid these intermittent failures by increasing the animation durations by 10x, so that they're much less likely to complete on their own. Note that the standard WPT test-timeout is 10s, so it's reasonable to expect that the test shouldn't take longer than that (and hence we won't accidentally let these animations play to completion before the test logic has a chance to advance them). This patch also updates the logic/expectations to account for the new duration. e.g. we now set currentTime to 19999 (19.999s) rather than 1.999 (1.99s), to advance to just before the end of the second repetition of our animation. And this means we'll be slightly further through the animation, so the test's assertions now expect an opacity of 0.9999 rather than just 0.999. Differential Revision: https://phabricator.services.mozilla.com/D224371 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1922353 gecko-commit: 438cafb138808a2b8f7921cd4abd89718a6c4c23 gecko-reviewers: boris
…non-selectable When `PeekOffsetForCharacter` find a non-editable content, it should never return the frame because user must want to move caret only in editable content when the previous position is editable. Additionally, when a non-selectable frame is skipped, caret will be moved enough, so it should not skip any editable content. Finally, the found frame may cause a line break. Therefore, this patch overwrites the result of `SelectablePeekReport::PeekOffsetForCharacter` from `FOUND` to `CONTINUE_UNSELECTABLE` when non-editable content is found. The remaining failures of the new WPT should be handled in bug 449685 because they are caused by no frame for invisible preceding/trailing white spaces around the block element boundary. Depends on D223909 Differential Revision: https://phabricator.services.mozilla.com/D224183 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1921705 gecko-commit: 755750429ced683c63011ab7eee8672d52c45e5d gecko-reviewers: emilio
…teditable=plaintext-only Chrome sets `beforeinput.data` instead of `beforeinput.dataTransfer`, but Input Events Level 2 spec defines that browsers should set `dataTransfer` when **contenteditable** [1]. Therefore, the new WPT expects `dataTransfer`. However, it's unclear that the `dataTransfer` should have `text/html` or only `text/plain`. From web apps point of view, `text/html` data may make them serialize the rich text format to plaintext without any dependencies of browsers and OS. On the other hand, they cannot distinguish whether the user tries to paste with or without formatting when `contenteditable=true`. Therefore, I filed a spec issue for this. We need to be back later about this issue. 1. https://w3c.github.io/input-events/#overview 2. w3c/input-events#162 Differential Revision: https://phabricator.services.mozilla.com/D223908 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1920646 gecko-commit: 2e3f866560e2c750fe1e4469b81d89f10bffc6a1 gecko-reviewers: m_kato
…converted from given source Differential Revision: https://phabricator.services.mozilla.com/D223909 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1920646 gecko-commit: 39f1a092f31fc2950ea974b4df5e8710f9bf500d gecko-reviewers: m_kato
Ugh Differential Revision: https://phabricator.services.mozilla.com/D224302 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1919031 gecko-commit: d8b7f10eb81d003d51523bbaea87ccc6b0b36abf gecko-reviewers: smaug
We're currently drawing a full-sweep open arc (sweep angle = 360 or -360) and full-sweep closed arc with the same function SkCanvas::drawArc(), which only draws open arcs. So it incorrectly draws open arc for closed path. This cl fixes the issue by converting the full sweep open arc to skpath. Bug: 370690269 Change-Id: I7aee5f953d7d04b1ea73730a41c64cd86911746e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5889468 Reviewed-by: Florin Malita <[email protected]> Commit-Queue: Yi Xu <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363662}
The 5906880 CL breaks Firefox's internal WPT test. The test itself is based on the unclear part of resume() and currentTime where the test tries to validate resume() method process the data, and increase the currentTime before its resolution, which isn't clear on the spec. The original test failed in the Chromium due to several bugs. https://crbug.com/372866278, https://crbug.com/40140417 We decided to revert the previous CL until we have clear spec and fix the chromium specific issues. https://crrev.com/c/5906880?tab=comments Bug: 40246707 Change-Id: I020a49f6c91c85f33262b5657f65a8d8d06d273e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5937369 Reviewed-by: Hongchan Choi <[email protected]> Reviewed-by: Michael Wilson <[email protected]> Commit-Queue: Sunggook Chue <[email protected]> Cr-Commit-Position: refs/heads/main@{#1370213}
This allows us to leverage GitHub Actions built-in support for JSON rather than trying to declare all the possible jobs as output variables.
Adding JavaScript Promise Integration tests from spec repo to WPT BYPASS_LARGE_CHANGE_WARNING Bug: 42202153 Change-Id: Ic691c83df8861456de69ab01fd048bf0c4472967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5922662 Reviewed-by: Shu-yu Guo <[email protected]> Commit-Queue: Francis McCabe <[email protected]> Reviewed-by: Andreas Haas <[email protected]> Cr-Commit-Position: refs/heads/main@{#1370246}
The update modifies "upgrade transaction" related WPTs to run not only in window environments but also on dedicated, service, and shared workers. Bug: 41455766 Change-Id: Ibdb5474722733d3a1c0d950f6893fe2c5bede6bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5905028 Reviewed-by: Steve Becker <[email protected]> Reviewed-by: Abhishek Shanthkumar <[email protected]> Commit-Queue: Garima Chadha <[email protected]> Auto-Submit: Garima Chadha <[email protected]> Cr-Commit-Position: refs/heads/main@{#1370305}
Change-Id: Iefd07280198060ac7ed46d326ea0379f2ca6df3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5920776 Reviewed-by: Xiyuan Xia <[email protected]> Reviewed-by: Xiaoqian Dai <[email protected]> Commit-Queue: Michael Ludwig <[email protected]> Cr-Commit-Position: refs/heads/main@{#1370373}
As per the feedback on this thread on the MLTensor explainer PR: webmachinelearning/webnn#754 (comment) This CL includes logic to still support specifying the deprecated MLTensorUsage flags for now, though this logic will only exist for about a milestone to give callers the opportunity to migrate their existing code Bug: 343638938 Change-Id: I56209e68fde3920b8d6c781c8f804ac6fcd35c9a Cq-Include-Trybots: luci.chromium.try:mac14.arm64-blink-rel,win11-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5933323 Reviewed-by: ningxin hu <[email protected]> Auto-Submit: Austin Sullivan <[email protected]> Commit-Queue: ningxin hu <[email protected]> Cr-Commit-Position: refs/heads/main@{#1370419}
Product nodes are eagerly resolved during parse time, but sum nodes are not. This might cause floating point inprecision in sum nodes, which leads to invalid calculations, e.g. `round(down, (7 - 1) / 3, 1)` would end up being `round(down, (2.3333333 - 0.33333334), 1)`, then `round(down, 1.99999996, 1)`, which equals `1`, which is incorrect. Differential Revision: https://phabricator.services.mozilla.com/D225936 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1924363 gecko-commit: 2943453155ac4ea275b37a12d30391c39f1a3c1e gecko-reviewers: layout-reviewers, emilio
Differential Revision: https://phabricator.services.mozilla.com/D225949 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1925252 gecko-commit: fe15a02a83f2dec2a89cc294523ea2a250ea1985 gecko-reviewers: smaug
…obal wasm/jsapi/assertions.js already does this, in order to be able to be imported as an ES module. See: tc39/proposal-shadowrealm#397
Other exports in this file already do this, in order to be able to be imported as an ES module. See: tc39/proposal-shadowrealm#397
…ame::GetRenderedText. For clarity, we refactor body of the loop-over-continuations in nsTextFrame::GetRenderedText into a helper method AppendRenderedText that handles a single continuation in the chain. This avoids the footgun of an nsTextFrame method iterating over its continuations (using the textFrame variable) but potentially calling methods of the primary frame within the loop, instead of the current frame being processed. Differential Revision: https://phabricator.services.mozilla.com/D225686 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1923829 gecko-commit: f2f6cefad4a196e4c78ceb4c6bd4699c5e6a4cb0 gecko-reviewers: dshin
Chrome M130 supports non-special URL, however, a regression is reported at http://crbug.com/373928202. The summary is: Chrome <= 129: | No | URL | valid url? | url.hostname | url.path | |----+------------------+------------+--------------+----------------| | 1 | TEST://PC/FOLDER | valid | "" | "//PC/FOLDER" | | 2 | TEST://PC\FOLDER | valid | "" | "//PC\FOLDER" | | 3 | TEST:\\PC\FOLDER | valid | "" | "\\PC\FOLDER" | | 4 | TEST:\\PC | valid | "" | "\\PC" | Chrome 130: | No | URL | valid url? | url.hostname | url.path | |----+------------------+------------+--------------+---------------| | 1 | TEST://PC/FOLDER | valid | "pc" | "/FOLDEDR" | | 2 | TEST://PC\FOLDER | invalid | - | - | | 3 | TEST:\\PC\FOLDER | invalid | - | - | | 4 | TEST:\\PC | valid | "pc" | "" | URL Standard (expected behaviors) | No | URL | valid url? | url.hostname | url.path | |----+------------------+------------+--------------+---------------| | 1 | TEST://PC/FOLDER | valid | "pc" | "/FOLDEDR" | | 2 | TEST://PC\FOLDER | invalid | - | - | | 3 | TEST:\\PC\FOLDER | valid | "" | "\\PC\FOLDER" | | 4 | TEST:\\PC | valid | "" | "\\PC" | The problems is URL No.3 or No4, where "\\" (two backslashes) follows after "scheme:", for which Chrome M130 is not spec-compliant. These URLs should be a valid opaque path URL, however, Chrome M130 treat them wrongly. The reason: The current (wrong) URL parser counts backslahses as well as slashes after "scheme:". This behavior is the correct behavior for a special URL, like "https:\\PC\\FOLDER", but NOT for non-special URLs, like "TEST:\\PC\\FOLDER", unfortunately. For your reference, the URL Standard says that at the following place: https://url.spec.whatwg.org/#scheme-state > 7. Otherwise, if url is special, set state to special authority > slashes state. > 8. Otherwise, if remaining starts with an U+002F (/), set state to > path or authority state and increase pointer by 1. > 9. Otherwise, set url’s path to the empty string and set state to > opaque path state. It's a bit cryptic, but if you read this part (and other parts too) carefully, it says so. :( Unfortunately, the current WPT doesn't cover these test cases, so we didn't notice this regression. This CL fixes a regression by implement that URL standard part, and also add WPT tests to prevent a regression. Bug: 40063064,373928202 Change-Id: Ia5ba5ff16426893c735775c62b7044842d16b46d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5939018 Reviewed-by: Adam Rice <[email protected]> Commit-Queue: Hayato Ito <[email protected]> Cr-Commit-Position: refs/heads/main@{#1370488}
Co-authored-by: wpt-pr-bot <[email protected]>
All released version of B&A support both the new and old fields. The new field allows the B&A server to provide the same precision to worklets as is available in on-device auctions. Bug: 374088337 Change-Id: Ia1a5d40501da41300c7d9fd5e4e3bd7bfc8303ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5940498 Reviewed-by: Maks Orlovich <[email protected]> Commit-Queue: Russ Hamilton <[email protected]> Cr-Commit-Position: refs/heads/main@{#1370523}
We incorrectly used exclusive ancestors, making it impossible to anchor against elements that both name and scope some anchor name. Fixed: 373815812 Change-Id: I5eaab2f38589f02470c5229573c199f1b3715424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5938970 Commit-Queue: Anders Hartvoll Ruud <[email protected]> Reviewed-by: Rune Lillesveen <[email protected]> Cr-Commit-Position: refs/heads/main@{#1370556}
This gets rid of a lot of duplication and makes this much simpler. This might be hard to use for PRs where we want to do different chunking (given the matrix definition), but that is a future challenge (one possibility is to just pass in a blob of JSON as an input and use matrix: fromJSON()).
AnalyzerNode handler isn't cleared out when context is suspended and it will be pulled again when it is resumed: This test is for validation of the below CL. https://chromium-review.googlesource.com/c/chromium/src/+/1903894. Bug: 40662255 Change-Id: Id06e9ee5fd4f0e8c97b763a64b5f16de699e0590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5930608 Reviewed-by: Gabriel Brito <[email protected]> Reviewed-by: Hongchan Choi <[email protected]> Reviewed-by: Michael Wilson <[email protected]> Commit-Queue: Sunggook Chue <[email protected]> Cr-Commit-Position: refs/heads/main@{#1370742}
This new test validates every single canvas composite operations by comparing against pycairo. Composite ops are validated with globalAlpha, transformations, with and without filters, with and without shadows, using different source raster types (normal fill style, drawImage and canvas patterns), and for all combinations of these. These variants are grouped into grids, with each generated test files validating all composite ops together. Chromium has similar tests, but they validate the result by either comparing against hard-coded expected color values, or against PNG files generated by saving the result of the test itself and using that as the expected results. The first approach is problematic because the expected color values are hard to compute and hard to validate. The second approach is also problematic because the tests only checks that the code doesn't start producing different results, they don't test that the results are actually correct. As a matter of fact, this new test surfaced an existing bug in Chromium where it doesn't correctly computes shadows when the "screen" composite op is used. Using pycairo has the advantage of providing an independent reference that is easy to generated programmatically. The reason pycairo was used here is simply that the Canvas WPT test generator already uses it. Bug: 364549423 Change-Id: If476f8ee29a1afbb2a759421f5e8e76b68702982
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/evaluate-expressions-in-workflows-and-actions#literals: > You don't need to enclose strings in ${{ and }}. However, if you do, > you must use single quotes (') around the string. To use a literal > single quote, escape the literal single quote using an additional > single quote (''). Wrapping with double quotes (") will throw an > error. And in a shocking turn of events, using double quotes did in fact throw an error.
It remains the case that many tests expect an sRGB color space, so set the color profile appropriately.
Usually, justify-self causes an element to shrink-to-fit in the absence of a preferred size. But we have to let an inline child of the justified element stretch so that any of _its_ block children can still stretch to the justified grandparent. Fixed: 374034249 Change-Id: I17b7fa89d84a76eacff2d2e6448db1b7bfe46a32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5942095 Reviewed-by: David Baron <[email protected]> Commit-Queue: David Grogan <[email protected]> Cr-Commit-Position: refs/heads/main@{#1370819}
With the unified workflow, we don't actually need to specify the wildcard, as this will just lead to errors like: > Error: The artifact name is not valid: > safari-technology-preview-results-*-6. Contains the following > character: Asterisk * e.g., in https://github.com/web-platform-tests/wpt/actions/runs/11410328782/job/31752427266
Similar to #48106, permission changes may leak between tests that use the same WebDriver session (i.e., browser process). For now, add a Chromium-specific `Browser.resetPermissions` call to reset permission defaults. To consolidate calls that reset state, refactor the WebDriver executor's testharness window management to align with #45735.
Explainer: WICG/shared-storage#199 Key points: - `SharedStorageWorkletNavigator` is a new interface that only supports `locks`. Implementation-wise, we inherit NavigatorBase so it's compatible with the LockManager implementation. Some methods are obviously unreachable (e.g. GetAcceptLanguages()). - Add the member `LockManager<OriginLockGroupId> lock_manager_;` to SharedStorageWorkletHostManager: The locks have a shared storage specific scope (separate from the Window/Worker locks), and are further partitioned by shared storage origin. Bug: 373899210 Change-Id: I9908962949088356c2a61c1556183ccd5772985f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5937903 Reviewed-by: Ayu Ishii <[email protected]> Reviewed-by: Xianzhu Wang <[email protected]> Reviewed-by: Ken Buchanan <[email protected]> Commit-Queue: Yao Xiao <[email protected]> Cr-Commit-Position: refs/heads/main@{#1370865}
…underlying value. Thanks to Robert Longson for writing an initial prototype-WPT that this WPT is based on. Differential Revision: https://phabricator.services.mozilla.com/D226091 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1925324 gecko-commit: b378432dac5f4dfae934158a2a34374227e1d90a gecko-reviewers: longsonr
This matches Blink with border / padding in nested blocks, and seems worth doing even if we paint the nested lines. Follow-up patch will prevent painting the nested lines. Differential Revision: https://phabricator.services.mozilla.com/D157572 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1791226 gecko-commit: 1c543fc925a7d0e1dc8b8f57dad98e170c233bed gecko-reviewers: layout-reviewers, dshin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )