Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New parse tree #96

Merged
merged 6 commits into from
Feb 19, 2024
Merged

New parse tree #96

merged 6 commits into from
Feb 19, 2024

Conversation

Andrew-Morozko
Copy link
Contributor

@Andrew-Morozko Andrew-Morozko commented Feb 16, 2024

  • New parse tree with better context support (Local context for content plugins invocation #17 )
  • Code cleanup/refactoring
  • Data command
    • data.<plugin-name>.<data-name> form
    • highlight json
  • Ctrl+C -cancelable context passed everywhere
  • Removed potential data conflict warning from anonymous data refs; now only show warning when actual data confilct happens (one data ref value is overwritten by another)
  • Use plugin.MapData instead of map[string]any in more places to prevent translating back and fourth between the types

Ready for review & merge!

@traut
Copy link
Member

traut commented Feb 19, 2024

looks good!

@Andrew-Morozko Andrew-Morozko merged commit bbe13c7 into main Feb 19, 2024
5 checks passed
@Andrew-Morozko Andrew-Morozko deleted the parse-tree branch February 19, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement data subcommand for Fabric Local context for content plugins invocation
3 participants