Plugin caller #60
Merged
Plugin caller #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrew-Morozko
commented
Jan 29, 2024
plugins/content/text/plugin.go
Outdated
| func (Plugin) GetPlugins() []plugin.Plugin { | ||
| return []plugin.Plugin{ | ||
| func (Plugin) GetPlugins() []plugininterface.Plugin { | ||
| // HACK: rpc: gob error encoding body: gob: type cty.Type has no exported fields |
There was a problem hiding this comment.
The problem is here. I welcome any suggestions, but it seems that we have to encode-decode specs into json.
There was a problem hiding this comment.
to rebroadcast from slack: looking at the hashicorp/packer-plugin-sdk#188, it seems hashicorp/go-plugin with gRPC and msgpack is the way to go
Andrew-Morozko
commented
Jan 30, 2024
Andrew-Morozko
force-pushed
the
plugin-caller
branch
from
61655f8 to
08b0792
Compare
Andrew-Morozko
force-pushed
the
plugin-caller
branch
from
fb55321 to
c1910aa
Compare
|
@Andrew-Morozko can we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Config and Invocation specs come over the rpc channel as nil:
rpc: gob error encoding body: gob: type cty.Type has no exported fieldsSee below