Better argument parsing #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ A limiter deadlock fix
2 times smaller and faster than google's version, allows for garbage collection after function execution
Seems like we won't really need them. Still a better performing version of sync.Once*, worth a PR to golang
I know that "utils" is a bad name, but it's such a basic string and function code. Might as well call it "stdlib forgot this"
Mostly avoidng loop variable capture by using the new utils to apply functions. Disabling gomnd, too annoying
(conforming to the spec)
traut
approved these changes
Jan 25, 2024
Merged
|
Replaced by #58 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swithched from default go flag parser to https://github.com/alexflint/go-arg.
Nicer help messages, etc. Some quick PR after the parser mess