All v0.2 + data.inline plugin implementations
#46
Conversation
UpdateImplemented |
plugins/content/list/plugin.go
Outdated
| if err != nil { | ||
| return "", err | ||
| } | ||
| buf.WriteString("* ") |
There was a problem hiding this comment.
to support the ordered lists, we can drop this line and either
- delegate the responsibility of setting
1.or*to the template string author - adding
orderedbool attribute (falseby default) to the block and setting ordered / unordered list prefixes ourselves.
I lean towards the 2nd option - the new ordered attribute. What do you think?
There was a problem hiding this comment.
How about keeping it similar with other content plugins naming?
format = "ordered"default would be "unordered"
There was a problem hiding this comment.
hm, it seems strange to have a string enum for a boolean flag, isn't it?
yeah, ok, we can do a task list there as well!
how about format values ordered, unordered, tasklist? wth unordered default value
There was a problem hiding this comment.
I see it more as a ListType. There is also alphabetical list type supported by md.
There was a problem hiding this comment.
Let's start with a simpler Github flavor for now, with the ability to extend if needed. I think ordered, unordered and tasklist should be enough for now.
If more extensive ordering / formatting is needed, the users can use jq / content.text with markdown code
plugins/content/openai/plugin.go
Outdated
| return "", errors.New("prompt is required in invocation") | ||
| } | ||
| params := client.ChatCompletionParams{ | ||
| Model: defaultModel, |
There was a problem hiding this comment.
oh, that's great -- could you please make it another content attribute? Just a string model attribute that accepts the name of the model and defaults to gpt-3.5-turbo?
Implementations of the following plugins:
data.inlineplugin #27data.txtplugin #31content.listplugin #40content.imageplugin #39content.openai_textplugin #41content.frontmatterplugin #47