Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More pre release fixes #212

Merged
merged 25 commits into from
Jul 14, 2024
Merged

More pre release fixes #212

merged 25 commits into from
Jul 14, 2024

Conversation

traut
Copy link
Member

@traut traut commented Jun 23, 2024

  • doc tweaks
  • logging tweaks
  • do not print to stdout if --publish is set
  • append \n to stdout output

@traut traut requested review from Andrew-Morozko and dobarx June 23, 2024 18:21
docs/tutorial.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Andrew-Morozko Andrew-Morozko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some suggestions and nitpicks

- `expose_env_vars_with_pattern`: (optional) a glob pattern for environment variable names. Only the
environment variables that match the pattern are exposed in the evaluation context. Default value
is `FABRIC_*`. To expose all environment variables, set the value to `*`. See [Environment
variables]({{< ref "configs.md#environment-variables">}}) for the details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: Setting to null or an empty string would expose no environment variables

@traut traut merged commit bcbe338 into main Jul 14, 2024
7 checks passed
@traut traut deleted the pre-release-fixes-042 branch July 14, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants