Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.3 plugins #105

Merged
merged 8 commits into from
Feb 21, 2024
Merged

v0.3 plugins #105

merged 8 commits into from
Feb 21, 2024

Conversation

dobarx
Copy link
Contributor

@dobarx dobarx commented Feb 20, 2024

All plugins from v0.3 milestone:

Other:

  • All data sources that return lists started to fail after previous PR. I've changed now expected result type of data source in parser from plugin.MapData to plugin.Data.
    @Andrew-Morozko Verify if this does not cause any issues with parser. (commit: 375015e)

@dobarx dobarx marked this pull request as ready for review February 20, 2024 17:49
@traut
Copy link
Member

traut commented Feb 20, 2024

it's funny that the CI checks do not re-run when the pull request becomes ready for review

@dobarx
Copy link
Contributor Author

dobarx commented Feb 20, 2024

it's funny that the CI checks do not re-run when the pull request becomes ready for review

It seems github actions trigger only on git events. Changing from draft to regular PR doesn't effect that.

@Andrew-Morozko
Copy link
Contributor

Fixed this in #106

@Andrew-Morozko
Copy link
Contributor

@Andrew-Morozko Verify if this does not cause any issues with parser. (commit: 375015e)

@dobarx Done, everything is OK

@dobarx dobarx merged commit 6d1efe7 into main Feb 21, 2024
7 checks passed
@dobarx dobarx deleted the v0_3_plugin branch February 21, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants