Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adi: break down adi_config_ap to decrease nesting #2003

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

adi: break down adi_config_ap to decrease nesting #2003

wants to merge 1 commit into from
+113 −102

Conversation

HrMitrev
Copy link
Contributor

@HrMitrev HrMitrev commented Nov 18, 2024 •
edited
Loading

Detailed description

This is just a refactoring commit to the reading of adi_configure_ap easier by decreasing nesting. The behavior should be the same

Your checklist for this pull request

@HrMitrev HrMitrev changed the title adi: broke down adi_config_ap to decrease nesting adi: break down adi_config_ap to decrease nesting Nov 18, 2024
dragonmux
dragonmux approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please rebase this on main (not git merge, but rather a full git rebase) and then we'll merge it. Thank you for the contribution!

@dragonmux dragonmux added this to the v2.0 release milestone Nov 19, 2024
@dragonmux dragonmux added the Enhancement General project improvement label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragonmux dragonmux dragonmux approved these changes

Assignees
No one assigned
Labels
Enhancement General project improvement
Projects
None yet
Milestone
v2.0 release
Development

Successfully merging this pull request may close these issues.
2 participants
@HrMitrev @dragonmux