Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wildcard deduplication #1972

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Fix wildcard deduplication #1972

merged 1 commit into from
Nov 18, 2024

Conversation

TheTechromancer
Copy link
Collaborator

Fixes #1859.

The problem was that the deduplication was happening before the event's data was changed to _wildcard. The solution was to make an additional dedup check after the data is changed.

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 93%. Comparing base (a55e9dd) to head (0c5220e).
Report is 25 commits behind head on dev.

Files with missing lines Patch % Lines
bbot/modules/internal/dnsresolve.py 88% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #1972   +/-   ##
=====================================
- Coverage     93%     93%   -0%     
=====================================
  Files        365     365           
  Lines      27915   27941   +26     
=====================================
+ Hits       25739   25746    +7     
- Misses      2176    2195   +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@TheTechromancer TheTechromancer merged commit e3e321a into dev Nov 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants