-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm): update node-feature-discovery ( 0.16.6 → 0.17.0 ) #3876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- kubernetes/apps/kube-system/node-feature-discovery/app Kustomization: flux-system/node-feature-discovery HelmRelease: kube-system/node-feature-discovery
+++ kubernetes/apps/kube-system/node-feature-discovery/app Kustomization: flux-system/node-feature-discovery HelmRelease: kube-system/node-feature-discovery
@@ -13,13 +13,13 @@
spec:
chart: node-feature-discovery
sourceRef:
kind: HelmRepository
name: node-feature-discovery
namespace: flux-system
- version: 0.16.6
+ version: 0.17.0
install:
crds: CreateReplace
remediation:
retries: 3
interval: 30m
upgrade: |
--- HelmRelease: kube-system/node-feature-discovery ClusterRole: kube-system/node-feature-discovery
+++ HelmRelease: kube-system/node-feature-discovery ClusterRole: kube-system/node-feature-discovery
@@ -5,12 +5,19 @@
name: node-feature-discovery
labels:
app.kubernetes.io/name: node-feature-discovery
app.kubernetes.io/instance: node-feature-discovery
app.kubernetes.io/managed-by: Helm
rules:
+- apiGroups:
+ - ''
+ resources:
+ - namespaces
+ verbs:
+ - watch
+ - list
- apiGroups:
- ''
resources:
- nodes
- nodes/status
verbs:
--- HelmRelease: kube-system/node-feature-discovery DaemonSet: kube-system/node-feature-discovery-worker
+++ HelmRelease: kube-system/node-feature-discovery DaemonSet: kube-system/node-feature-discovery-worker
@@ -33,23 +33,23 @@
allowPrivilegeEscalation: false
capabilities:
drop:
- ALL
readOnlyRootFilesystem: true
runAsNonRoot: true
- image: registry.k8s.io/nfd/node-feature-discovery:v0.16.6
+ image: registry.k8s.io/nfd/node-feature-discovery:v0.17.0
imagePullPolicy: IfNotPresent
livenessProbe:
grpc:
port: 8082
initialDelaySeconds: 10
readinessProbe:
- failureThreshold: 10
grpc:
port: 8082
initialDelaySeconds: 5
+ failureThreshold: 10
env:
- name: NODE_NAME
valueFrom:
fieldRef:
fieldPath: spec.nodeName
- name: POD_NAME
@@ -66,13 +66,12 @@
requests:
cpu: 5m
memory: 64Mi
command:
- nfd-worker
args:
- - -feature-gates=NodeFeatureAPI=true
- -feature-gates=NodeFeatureGroupAPI=false
- -metrics=8081
- -grpc-health=8082
ports:
- containerPort: 8081
name: metrics
@@ -94,15 +93,12 @@
- name: host-lib
mountPath: /host-lib
readOnly: true
- name: host-proc-swaps
mountPath: /host-proc/swaps
readOnly: true
- - name: source-d
- mountPath: /etc/kubernetes/node-feature-discovery/source.d/
- readOnly: true
- name: features-d
mountPath: /etc/kubernetes/node-feature-discovery/features.d/
readOnly: true
- name: nfd-worker-conf
mountPath: /etc/kubernetes/node-feature-discovery
readOnly: true
@@ -122,15 +118,12 @@
- name: host-lib
hostPath:
path: /lib
- name: host-proc-swaps
hostPath:
path: /proc/swaps
- - name: source-d
- hostPath:
- path: /etc/kubernetes/node-feature-discovery/source.d/
- name: features-d
hostPath:
path: /etc/kubernetes/node-feature-discovery/features.d/
- name: nfd-worker-conf
configMap:
name: node-feature-discovery-worker-conf
--- HelmRelease: kube-system/node-feature-discovery Deployment: kube-system/node-feature-discovery-master
+++ HelmRelease: kube-system/node-feature-discovery Deployment: kube-system/node-feature-discovery-master
@@ -34,26 +34,26 @@
allowPrivilegeEscalation: false
capabilities:
drop:
- ALL
readOnlyRootFilesystem: true
runAsNonRoot: true
- image: registry.k8s.io/nfd/node-feature-discovery:v0.16.6
+ image: registry.k8s.io/nfd/node-feature-discovery:v0.17.0
imagePullPolicy: IfNotPresent
+ startupProbe:
+ grpc:
+ port: 8082
+ failureThreshold: 30
livenessProbe:
grpc:
port: 8082
- initialDelaySeconds: 10
readinessProbe:
- failureThreshold: 10
grpc:
port: 8082
- initialDelaySeconds: 5
+ failureThreshold: 10
ports:
- - containerPort: 8080
- name: grpc
- containerPort: 8081
name: metrics
- containerPort: 8082
name: health
env:
- name: NODE_NAME
@@ -66,14 +66,13 @@
limits:
memory: 4Gi
requests:
cpu: 100m
memory: 128Mi
args:
- - -crd-controller=true
- - -feature-gates=NodeFeatureAPI=true
+ - -enable-leader-election
- -feature-gates=NodeFeatureGroupAPI=false
- -metrics=8081
- -grpc-health=8082
volumeMounts:
- name: nfd-master-conf
mountPath: /etc/kubernetes/node-feature-discovery
--- HelmRelease: kube-system/node-feature-discovery Deployment: kube-system/node-feature-discovery-gc
+++ HelmRelease: kube-system/node-feature-discovery Deployment: kube-system/node-feature-discovery-gc
@@ -27,13 +27,13 @@
serviceAccountName: node-feature-discovery-gc
dnsPolicy: ClusterFirstWithHostNet
securityContext: {}
hostNetwork: false
containers:
- name: gc
- image: registry.k8s.io/nfd/node-feature-discovery:v0.16.6
+ image: registry.k8s.io/nfd/node-feature-discovery:v0.17.0
imagePullPolicy: IfNotPresent
env:
- name: NODE_NAME
valueFrom:
fieldRef:
fieldPath: spec.nodeName
--- HelmRelease: kube-system/node-feature-discovery Job: kube-system/node-feature-discovery-prune
+++ HelmRelease: kube-system/node-feature-discovery Job: kube-system/node-feature-discovery-prune
@@ -27,13 +27,13 @@
allowPrivilegeEscalation: false
capabilities:
drop:
- ALL
readOnlyRootFilesystem: true
runAsNonRoot: true
- image: registry.k8s.io/nfd/node-feature-discovery:v0.16.6
+ image: registry.k8s.io/nfd/node-feature-discovery:v0.17.0
imagePullPolicy: IfNotPresent
command:
- nfd-master
args:
- -prune
restartPolicy: Never |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
0.16.6
->0.17.0
Release Notes
kubernetes-sigs/node-feature-discovery (node-feature-discovery)
v0.17.0
Compare Source
Changelog
Configurable restrictions (EXPERIMENTAL)
The nfd-master now has configuration options to restrict its capabilities, that is what modifications on node objects are allowed. See the nfd-master configuration file reference for documentation.
Image compatibity (EXPERIMENTAL)
There is an initiative to utilize NFD to implement system compatibility requirements for container images. As part of this work NFD v0.17 includes
nfd
command line client for validating systems against image compatibility manifests. See the documentation for more details, including examples how to create container images with compatibility manifests and validating nodes.See the enhancement proposal for background information and design details.
Miscellaneous
Scalability
This release contains numerous fixes to fix issues and improve the scalability of NFD in larger clusters.
DMI features
Discovery of
system.dmiid.product_name
was added.CPUID features
Support for new CPUID flags were added, including AMX-FP8 and AVX-VNNI-INT16.
Helm chart
Numerous small improvements in the NFD Helm chart, mainly new configuration values (see chart parameters for documentation).
Deprecations
gRPC API
The NodeFeature API is now GA and the legacy gRPC API has been completely removed.
Hooks
Support for hooks (deprecated in v0.12 has been removed. See the customization guide for replacements.
ResourceLabels config option
The
resourceLabels
configuration file option (and the corresponding-resource-labels
flag), deprecated in v0.13 were removed. Use NodeFeatureRule object's extendedResources field instead.Dynamic configuration
Dynamic runt-time reconfiguration was removed. This improves robustness and consistency as some of the configuration options did not support dynamic configuration.
Upcoming changes
The separate metric and health ports will be united behind a single port and the corresponding Helm chart values will be removed in NFD v0.18. This should be invisible to most users.
List of PRs
(Full Changelog: kubernetes-sigs/node-feature-discovery@v0.17.0-devel...v0.17.0)
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.