-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix tiktok download #20
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the approach, but I don't think you need to assign the webpage variable twice. simply calling self._download_webpage does the trick
Unfortunately there is no retry option for downloading webpages or info files like in json. |
Co-authored-by: Merval <[email protected]>
@GreyAlien502 We should look at implementing what @blackjack4494 is referring to. Check the page status code, and call a second time if we get 503 back. |
@blackjack4494, We aren't retrying anything here,
Oh, i wasn't aware that the current code was working for anyone (without providing cookies).
I just tried --force-generic, and it sometimes works for me. |
@merval, an |
self._download_webpage(url, video_id) | ||
webpage = self._download_webpage(url, video_id, note='Downloading video webpage') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change this so that it won't download the webpage twice if not necessary. You can check the result and implement some try again but only once if response isn't satisfying.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If anyone can provide a way of determining if the response is satisfying, i can add such a check.
I don't see any meaningful difference between the first and second responses i receive.
Is there a specific reason why you think such a check would be possible?
tiktok download is down again. U:\youtube-dlc -i -o "%(id)s.mp4" -v https://www.tiktok.com/@tiktok_stage/video/6885152542095887617 |
btw, this was fixed in ytdl-org/youtube-dl by adding the extra call to tiktok in the |
@tanliang1 Provide the full verbose output (with Also, you might want to try it on the master of yt-dlp. I have applied a tiny patch on top of this PR |
Only VOD extractor has been implemented Related: ytdl-org/youtube-dl#26125 Related: blackjack4494#220
Currently, tiktok downloads fail with status 403.
This request fixes that by downloading the page twice before trying the video.
This seems like a bug on their end since i noticed the same problem in the webapp:
the request for the video file fails with 403 when opening a video in a fresh incognito session, but it works when i reload.