Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #93 YoutubePlaylistsIE #147

Merged
merged 1 commit into from
Nov 10, 2020
Merged

Conversation

ZenulAbidin
Copy link
Contributor

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Changes the regular expressions in YoutubePlaylistsIE to accommodate the new JSON endpoint, fixing a bug where downloading a user's entire set of playlists no longer works.

@someziggyman
Copy link

Though this would fix the recent problem listed here
#148

But unfortunately it did not. These could however be not related.

@ZenulAbidin
Copy link
Contributor Author

Though this would fix the recent problem listed here
#148

But unfortunately it did not. These could however be not related.

This PR only fixes the playlists in the channel, not the videos. I’d need to make a separate fix for that.

@insaneracist
Copy link
Contributor

this seems good 👍

@blackjack4494 blackjack4494 merged commit 0e0cffb into blackjack4494:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants