Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zoom] new extractor #108

Merged

Conversation

insaneracist
Copy link
Contributor

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Fixes #107
Original pull request: https://github.com/unqueued/youtube-dl-prs/tree/pr/24751
I think the password field detection needs updating, however it downloads public videos.

@someziggyman
Copy link

seems to be working fine with all the Zoom links I've tried. Public and a couple password protected. Good job!

@insaneracist
Copy link
Contributor Author

shouldn't this extractor be called zoom rather than zoomus?

@blackjack4494
Copy link
Owner

shouldn't this extractor be called zoom rather than zoomus?

yup

@insaneracist insaneracist changed the title [zoomus] new extractor [zoom] new extractor Nov 4, 2020
@blackjack4494 blackjack4494 merged commit f8ddb38 into blackjack4494:master Nov 4, 2020
@someziggyman
Copy link

While this awesome extractor seems to be working fine, I've come across this password protected link today and it seems to have some custom theme on the page. Extractor does not see or identify it as one it can handle. Don't have a password to it yet to test if it works with --password parameter forced.

https://shopify.zoom.us/rec/share/J_bW4XEaoXCiUUP-oJjnMKF48xFhF8PMBJes_8pcLWqr8P3b1Xf0ljwz06Wxk2j5.N5Ed9tm6fJNI5BxA

Please see the log below:
_./testdlc -F -v https://shopify.zoom.us/rec/share/J_bW4XEaoXCiUUP-oJjnMKF48xFhF8PMBJes_8pcLWqr8P3b1Xf0ljwz06Wxk2j5.N5Ed9tm6fJNI5BxA
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-F', u'-v', u'https://shopify.zoom.us/rec/share/J_bW4XEaoXCiUUP-oJjnMKF48xFhF8PMBJes_8pcLWqr8P3b1Xf0ljwz06Wxk2j5.N5Ed9tm6fJNI5BxA']
[debug] Loading archive file None
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dlc version 2020.10.25
[debug] Python version 2.7.16 (CPython) - Darwin-19.6.0-x86_64-i386-64bit
[debug] exe versions: none
[debug] Proxy map: {}
[generic] J_bW4XEaoXCiUUP-oJjnMKF48xFhF8PMBJes_8pcLWqr8P3b1Xf0ljwz06Wxk2j5: Requesting header
WARNING: Falling back on generic information extractor.
[generic] J_bW4XEaoXCiUUP-oJjnMKF48xFhF8PMBJes_8pcLWqr8P3b1Xf0ljwz06Wxk2j5: Downloading webpage
[generic] J_bW4XEaoXCiUUP-oJjnMKF48xFhF8PMBJes_8pcLWqr8P3b1Xf0ljwz06Wxk2j5: Extracting information
ERROR: Unsupported URL: https://shopify.zoom.us/rec/share/J_bW4XEaoXCiUUP-oJjnMKF48xFhF8PMBJes_8pcLWqr8P3b1Xf0ljwz06Wxk2j5.N5Ed9tm6fJNI5BxA
Traceback (most recent call last):
File "./testdlc/youtube_dlc/extractor/generic.py", line 2387, in _real_extract
doc = compat_etree_fromstring(webpage.encode('utf-8'))
File "./testdlc/youtube_dlc/compat.py", line 2562, in compat_etree_fromstring
doc = _XML(text, parser=etree.XMLParser(target=_TreeBuilder(element_factory=_element_factory)))
File "./testdlc/youtube_dlc/compat.py", line 2551, in _XML
parser.feed(text)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/xml/etree/ElementTree.py", line 1659, in feed
self._raiseerror(v)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/xml/etree/ElementTree.py", line 1523, in _raiseerror
raise err
ParseError: syntax error: line 1, column 0
Traceback (most recent call last):
File "./testdlc/youtube_dlc/YoutubeDL.py", line 830, in extract_info
ie_result = ie.extract(url)
File "./testdlc/youtube_dlc/extractor/common.py", line 532, in extract
ie_result = self._real_extract(url)
File "./testdlc/youtube_dlc/extractor/generic.py", line 3382, in real_extract
raise UnsupportedError(url)
UnsupportedError: Unsupported URL: https://shopify.zoom.us/rec/share/J_bW4XEaoXCiUUP-oJjnMKF48xFhF8PMBJes_8pcLWqr8P3b1Xf0ljwz06Wxk2j5.N5Ed9tm6fJNI5BxA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

need zoomus extractor
4 participants