[Bandcamp] update - fix regexp for JSON matching #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scape the title properly
…the URL to match the tracks
… artist - track, and add missing keys from info_dict
…data, including album titles
|
@gilou I guess your latest commit finished the whole PR? Let me know if you plan to change some more. Otherwise I will merge it tomorrow. |
|
Let others people jump in and acknowledge the last version maybe hehe, or test it yourself. But I'm happy with it. I didn't know about youtube-dlc and the current youtube-dl situation, that is not a happy solution, but I guess you took action to make things happen, so it's not too bad… Yet a fork in that case is really not the nicest solution, I'm not sure why youtube-dl can't onboard new maintainers… |
… may fail, as the other title json values might come up), instead of out of trackinfo, as bandcamp prefixes it with artist -
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gilou
ytdl-org#26684
#148 @dym-sh
related
ytdl-org#26848