Update signJar Gradle task to use the new Windows jar signing client #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niravrsynopsys
requested review from
gopannabd,
dterrysynopsys,
shantyk,
devmehtabd and
andrian-sevastyanov
andrian-sevastyanov
approved these changes
Nov 26, 2024
shantyk
reviewed
Nov 29, 2024
| @@ -256,7 +256,7 @@ task signJar() { | |||
| finalizedBy 'verifyJar' | |||
| doLast { | |||
| exec { | |||
| commandLine 'jarsigner', '-tsa', 'http://rfc3161timestamp.globalsign.com/advanced', '-storetype', 'pkcs12', '-storepass', "${jarSigningKeystorePassword}", '-keystore', "${jarSigningKeystorePath}", "${createArtifactName()}", "${jarSigningCertificateAlias}" | |||
| commandLine 'signing-client', '--username', "${System.getenv('SIGNING_USER')}", '--password', "env:SIGNING_TOKEN", '--server', "${System.getenv('SIGNING_SERVER')}", '--port', '8000', '--signer', 'jarsigner', '--output', "${createArtifactName()}", "${createArtifactName()}" | |||
There was a problem hiding this comment.
How did you check what certificate (BD or Synopsys IT) was used to sign the JAR after these changes? (Would running "jarsigner -verify -strict -certs -verbose detect-10.1.0.jar" and confirming there are no mention of Synopsys be good enough during the 10.1.0 release?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new windows jar signing client enables signing jars using a Black Duck certificate and this server is centrally managed by release engineering. The code signing process is controlled by the "signJar" Gradle task.
This task needs to be updated to use the new signing client only for Detect versions 10.1.0 and above.
For all previous Detect versions, the Gradle task should continue using the existing code signing workfow that signs the jar with Synopsys certs.
JIRA
IDETECT-4518