This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Search first page #711
Merged
Search first page #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Todo: unit tests |
Blackbaud-PatrickOFriel
requested review from
Blackbaud-BobbyEarl,
Blackbaud-PaulCrowder and
Blackbaud-AdamHickey
Codecov Report
@@ Coverage Diff @@
## master #711 +/- ##
==========================================
+ Coverage 99.94% 99.94% +<.01%
==========================================
Files 286 286
Lines 5120 5121 +1
Branches 597 597
==========================================
+ Hits 5117 5118 +1
Misses 3 3
Continue to review full report at Codecov.
|
Blackbaud-BobbyEarl
approved these changes
Jun 1, 2017
| this.dispatcher.searchSetText(searchText); | ||
| this.dispatcher.next( | ||
| new ListPagingSetPageNumberAction(Number(1)) |
There was a problem hiding this comment.
The spacing seems slightly off for this line and the one below it.
There was a problem hiding this comment.
I'll change the spacing to be consistent, thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#706