Modal overflow ie11 #567
Modal overflow ie11 #567
Conversation
Blackbaud-PatrickOFriel
requested review from
Blackbaud-BobbyEarl and
Blackbaud-PaulCrowder
Codecov Report
@@ Coverage Diff @@
## master #567 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 269 269
Lines 4280 4283 +3
Branches 452 452
=====================================
+ Hits 4280 4283 +3
Continue to review full report at Codecov.
|
| max-height to the content that accounts for standard header and footer height. | ||
| */ | ||
| let modalContentEl = modalEl.nativeElement.querySelector('.sky-modal-content'); | ||
| let contentHeight = newHeight - 114; |
There was a problem hiding this comment.
114px = 50px for header + 64px for footer?
If that's the case, what happens if the header or footer contents ever wrap to multiple lines?
There was a problem hiding this comment.
Yep, if that happens, then specifically on IE11, things might go wrong (on all other browsers that implement flex correctly (which is all of them), the proper limits will still be set). Since I have not seen a design that has that happening (on purpose), I think this is a better solution than doing something with worse performance like watching for the header/footer contents to render/change height.
#564