Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Allow asynchronous List View Grid headings #1436

Merged
merged 11 commits into from
Feb 7, 2018
Merged

Allow asynchronous List View Grid headings #1436

merged 11 commits into from
Feb 7, 2018

Conversation

Blackbaud-SteveBrush
Copy link
Member

Addresses: #1394

@codecov-io
Copy link

codecov-io commented Jan 26, 2018 •
edited
Loading

Codecov Report

Merging #1436 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1436   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         370     370           
  Lines        6942    6961   +19     
  Branches      892     895    +3     
======================================
+ Hits         6942    6961   +19
Impacted Files Coverage Δ
src/modules/grid/grid.component.ts 100% <100%> (ø) ⬆️
src/modules/grid/grid-column.component.ts 100% <100%> (ø) ⬆️
...modules/list-view-grid/list-view-grid.component.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76c5998...5487b8d. Read the comment docs.

@Blackbaud-SteveBrush Blackbaud-SteveBrush changed the title Allow asynchronous List View Grid headings [HOLD] Allow asynchronous List View Grid headings Jan 26, 2018
@Blackbaud-SteveBrush Blackbaud-SteveBrush changed the title [HOLD] Allow asynchronous List View Grid headings Allow asynchronous List View Grid headings Jan 30, 2018
Blackbaud-BobbyEarl
Blackbaud-BobbyEarl approved these changes Feb 7, 2018
View reviewed changes
Copy link

@Blackbaud-BobbyEarl Blackbaud-BobbyEarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit f4d21a6 into master Feb 7, 2018
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the fix-grid-async-header branch February 7, 2018 13:23
@Blackbaud-SteveBrush Blackbaud-SteveBrush mentioned this pull request Feb 8, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Blackbaud-BobbyEarl Blackbaud-BobbyEarl Blackbaud-BobbyEarl approved these changes

@Blackbaud-PaulCrowder Blackbaud-PaulCrowder Awaiting requested review from Blackbaud-PaulCrowder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Blackbaud-SteveBrush @codecov-io @Blackbaud-BobbyEarl