Using Builder's typescript configs; fixed modal warning

src/app/components/wait/wait-demo.component.ts

@@ -9,9 +9,10 @@ import {
   templateUrl: './wait-demo.component.html'
 })
 export class SkyWaitDemoComponent {
-
   public isWaiting = false;
 
+  constructor(private waitSvc: SkyWaitService) { }
+
   public showPageWait(isBlocking: boolean) {
     if (isBlocking) {
       this.waitSvc.beginBlockingPageWait();
@@ -25,6 +26,4 @@ export class SkyWaitDemoComponent {
       }, 2000);
     }
   }
-
-  constructor(private waitSvc: SkyWaitService) { }
 }

src/modules/colorpicker/colorpicker-component.spec.ts

@@ -117,15 +117,15 @@ describe('Colorpicker Component', () => {
     fixture.whenStable();
     let inputElement: NodeListOf<Element> =
       element.querySelectorAll('.rgba-text > div:last-child > input');
-    let input = {
+    let input: any = {
       'hex': inputElement[0],
       'red': inputElement[1],
       'green': inputElement[2],
       'blue': inputElement[3],
       'alpha': inputElement[4]
     };
     input[name].value = value;
-    let params = {
+    let params: any = {
       'bubbles': false,
       'cancelable': false
     };

src/modules/colorpicker/colorpicker.component.ts

@@ -32,10 +32,10 @@ let componentIdIndex = 0;
 })
 
 export class SkyColorpickerComponent implements OnInit {
-
   @Output()
   public selectedColorChanged: EventEmitter<SkyColorpickerOutput> =
-  new EventEmitter<SkyColorpickerOutput>();
+    new EventEmitter<SkyColorpickerOutput>();
+
   public idIndex: number;
   public skyColorpickerHexId: string;
   public skyColorpickerRedId: string;
@@ -56,12 +56,26 @@ export class SkyColorpickerComponent implements OnInit {
   public selectedColor: SkyColorpickerOutput;
   public slider: SliderPosition;
   public initialColor: string;
+
   @ViewChild('closeColorPicker')
   private closeColorPicker: ElementRef;
+
   private outputColor: string;
   private hsva: SkyColorpickerHsva;
   private sliderDimMax: SliderDimension;
 
+  constructor(private service: SkyColorpickerService) {
+    componentIdIndex++;
+
+    this.idIndex = componentIdIndex;
+    this.skyColorpickerRedId = 'sky-colorpicker-red-' + this.idIndex;
+    this.skyColorpickerHexId = 'sky-colorpicker-hex-' + this.idIndex;
+    this.skyColorpickerRedId = 'sky-colorpicker-red-' + this.idIndex;
+    this.skyColorpickerGreenId = 'sky-colorpicker-green-' + this.idIndex;
+    this.skyColorpickerBlueId = 'sky-colorpicker-blue-' + this.idIndex;
+    this.skyColorpickerAlphaId = 'sky-colorpicker-alpha-' + this.idIndex;
+  }
+
   @HostListener('click', ['$event'])
   public onClick(event: any) {
     let element: HTMLButtonElement = <HTMLButtonElement>event.target;
@@ -87,19 +101,6 @@ export class SkyColorpickerComponent implements OnInit {
     }
   }
 
-  constructor(
-    private service: SkyColorpickerService
-  ) {
-    componentIdIndex++;
-    this.idIndex = componentIdIndex;
-    this.skyColorpickerRedId = 'sky-colorpicker-red-' + this.idIndex;
-    this.skyColorpickerHexId = 'sky-colorpicker-hex-' + this.idIndex;
-    this.skyColorpickerRedId = 'sky-colorpicker-red-' + this.idIndex;
-    this.skyColorpickerGreenId = 'sky-colorpicker-green-' + this.idIndex;
-    this.skyColorpickerBlueId = 'sky-colorpicker-blue-' + this.idIndex;
-    this.skyColorpickerAlphaId = 'sky-colorpicker-alpha-' + this.idIndex;
-  }
-
   public setDialog(
     instance: any,
     elementRef: ElementRef,

src/modules/fileattachments/file-item.component.ts

@@ -23,17 +23,19 @@ import {
 
 })
 export class SkyFileItemComponent implements DoCheck {
-
   @Input()
   public fileItem: SkyFileItem | SkyFileLink;
 
   @Output()
   public deleteFile = new EventEmitter<SkyFileLink | SkyFileItem>();
 
   private otherCls: string;
-
   private differ: KeyValueDiffer<any, any>;
 
+  public constructor(private differs: KeyValueDiffers) {
+    this.differ = this.differs.find({}).create(undefined);
+  }
+
   public ngDoCheck() {
     let changes = this.differ.diff(this.fileItem);
 
@@ -102,10 +104,6 @@ export class SkyFileItemComponent implements DoCheck {
     }
   }
 
-  public constructor(private differs: KeyValueDiffers) {
-    this.differ = this.differs.find({}).create(undefined);
-  }
-
   public itemDelete() {
     this.deleteFile.emit(this.fileItem);
   }

src/modules/grid/grid-column.component.ts

@@ -32,13 +32,13 @@ export class SkyGridColumnComponent {
   @Input()
   public isSortable: boolean = true;
 
-  /* tslint:disable */
+  /* tslint:disable:no-input-rename */
   @Input('search')
-  private searchFunction: (value: any, searchText: string) => boolean = this.search;
+  public searchFunction: (value: any, searchText: string) => boolean = this.search;
 
   @Input('template')
-  private templateInput: TemplateRef<any>;
-  /* tslint:enable */
+  public templateInput: TemplateRef<any>;
+  /* tslint:enable:no-input-rename */
 
   @ContentChildren(TemplateRef)
   private templates: QueryList<TemplateRef<any>>;

src/modules/list-filters/list-filter-inline.model.ts

@@ -9,18 +9,10 @@ export class SkyListFilterInlineModel {
   public name: string;
   public value: any;
   public defaultValue: any;
-
   public filterFunction: (item: ListItemModel, filter: any) => boolean;
-
   public onChange: EventEmitter<any> = new EventEmitter<any>();
-
   public template: TemplateRef<any>;
 
-  public changed(value: any) {
-    this.value = value;
-    this.onChange.emit(value);
-  }
-
   constructor(data?: any) {
     if (data) {
       this.name = data.name;
@@ -30,4 +22,9 @@ export class SkyListFilterInlineModel {
       this.defaultValue = data.defaultValue;
     }
   }
+
+  public changed(value: any) {
+    this.value = value;
+    this.onChange.emit(value);
+  }
 }

src/modules/list-secondary-actions/list-secondary-actions.spec.ts

@@ -61,40 +61,35 @@ describe('List Secondary Actions Component', () => {
       // run detectChanges once more then begin tests
       state.skip(1).take(1).subscribe(() => fixture.detectChanges());
     }
-      it('should show secondary actions when specified', async(() => {
-        initializeToolbar();
-        fixture.detectChanges();
-        fixture.whenStable().then(() => {
-          fixture.detectChanges();
-
-          /* tslint:disable */
-          let query =
-            '.sky-list-toolbar-container .sky-toolbar-item .sky-list-secondary-actions .sky-dropdown .sky-dropdown-menu sky-list-secondary-action';
-          /* tslint:enable */
-          expect(nativeElement.querySelector(query)).not.toBeNull();
-        });
 
-      }));
-
-      it('should hide secondary actions when no child actions available', fakeAsync(() => {
-        component.showOption = false;
-        initializeToolbar();
-        fixture.detectChanges();
-        tick();
+    it('should show secondary actions when specified', async(() => {
+      initializeToolbar();
+      fixture.detectChanges();
+      fixture.whenStable().then(() => {
         fixture.detectChanges();
-        /* tslint:disable */
+
+        /* tslint:disable:max-line-length */
         let query =
-          '.sky-list-toolbar-container .sky-toolbar-item .sky-list-secondary-actions';
-        /* tslint:enable */
+          '.sky-list-toolbar-container .sky-toolbar-item .sky-list-secondary-actions .sky-dropdown .sky-dropdown-menu sky-list-secondary-action';
+        /* tslint:enable:max-line-length */
+        expect(nativeElement.querySelector(query)).not.toBeNull();
+      });
+    }));
 
-        expect(component.secondaryActions.dropdownHidden.valueOf()).toBe(true);
+    it('should hide secondary actions when no child actions available', fakeAsync(() => {
+      component.showOption = false;
+      initializeToolbar();
+      fixture.detectChanges();
+      tick();
+      fixture.detectChanges();
 
-        component.showOption = true;
-        fixture.detectChanges();
-        tick();
-        expect(component.secondaryActions.dropdownHidden.valueOf()).toBe(false);
+      expect(component.secondaryActions.dropdownHidden.valueOf()).toBe(true);
 
-      }));
+      component.showOption = true;
+      fixture.detectChanges();
+      tick();
 
-    });
+      expect(component.secondaryActions.dropdownHidden.valueOf()).toBe(false);
+    }));
+  });
 });

src/modules/list-view-checklist/list-view-checklist.component.spec.ts

@@ -478,7 +478,7 @@ describe('List View Checklist Component', () => {
       expect(clearAllEl).toBeNull();
 
       let toolbarSectionsEl = nativeElement.querySelectorAll('sky-toolbar-section');
-      expect(toolbarSectionsEl.item(1).attributes['hidden']).not.toBeUndefined();
+      expect((toolbarSectionsEl.item(1) as any).attributes['hidden']).not.toBeUndefined();
 
     }));
 

src/modules/list/list-view.component.ts

@@ -3,16 +3,13 @@ import {
 } from '@angular/core';
 
 import { ListState } from './state';
-
 import { SkyListComponent } from '../list/list.component';
-import {
-  BehaviorSubject
-} from 'rxjs/BehaviorSubject';
+
 import {
   Observable
 } from 'rxjs/Observable';
 
-let moment = require('moment');
+const moment = require('moment');
 
 export abstract class ListViewComponent implements OnDestroy {
   public active: Observable<boolean>;
@@ -23,9 +20,6 @@ export abstract class ListViewComponent implements OnDestroy {
   protected subscriptions: Array<any> = [];
   protected hasToolbar: Observable<boolean>;
 
-  /* tslint:disable */
-  private initialized: BehaviorSubject<boolean> = new BehaviorSubject(false);
-  /* tslint:enable */
   private viewId: string = moment().toDate().getTime().toString();
 
   constructor(state: ListState, defaultName: string) {

src/modules/list/list.component.spec.ts

@@ -612,7 +612,7 @@ describe('List Component', () => {
 
       describe('models and state', () => {
         it('should handle no data passed to constructor', () => {
-          let item = new ListFilterModel();
+          new ListFilterModel();
         });
       });
     });
@@ -820,8 +820,7 @@ describe('List Component', () => {
           fixture: any,
           dataProvider: SkyListInMemoryDataProvider,
           nativeElement: HTMLElement,
-          element: DebugElement,
-          bs: BehaviorSubject<any>;
+          element: DebugElement;
 
       beforeEach(async(() => {
         dispatcher = new ListStateDispatcher();
@@ -882,8 +881,7 @@ describe('List Component', () => {
           component: ListTestComponent,
           fixture: any,
           nativeElement: HTMLElement,
-          element: DebugElement,
-          bs: BehaviorSubject<any>;
+          element: DebugElement;
 
       beforeEach(async(() => {
         dispatcher = new ListStateDispatcher();

src/modules/modal/modal-host.service.ts

@@ -1,9 +1,7 @@
 import {
-  EventEmitter,
-  Injectable
+  EventEmitter
 } from '@angular/core';
 
-@Injectable()
 export class SkyModalHostService {
   public static get openModalCount(): number {
     return SkyModalHostService.modalHosts.length;
@@ -31,7 +29,7 @@ export class SkyModalHostService {
   public close = new EventEmitter<void>();
   public openHelp = new EventEmitter<any>();
 
-  public constructor(private fullPage: boolean) {
+  constructor(private fullPage: boolean) {
     SkyModalHostService.modalHosts.push(this);
   }
 

src/modules/modal/modal.component.ts

@@ -42,7 +42,6 @@ let skyModalUniqueIdentifier: number = 0;
 })
 export class SkyModalComponent implements AfterViewInit {
   public modalState = 'in';
-
   public modalContentId: string = 'sky-modal-content-id-' + skyModalUniqueIdentifier.toString();
   public modalHeaderId: string = 'sky-modal-header-id-' + skyModalUniqueIdentifier.toString();
 
@@ -87,6 +86,14 @@ export class SkyModalComponent implements AfterViewInit {
     return this.config.helpKey;
   }
 
+  constructor(
+    private hostService: SkyModalHostService,
+    private config: SkyModalConfiguration,
+    private elRef: ElementRef,
+    private windowRef: SkyWindowRefService,
+    private componentAdapter: SkyModalComponentAdapterService
+  ) { }
+
   @HostListener('document:keydown', ['$event'])
   public onDocumentKeyDown(event: KeyboardEvent) {
     /* istanbul ignore else */
@@ -131,13 +138,6 @@ export class SkyModalComponent implements AfterViewInit {
     }
   }
 
-  constructor(
-    private hostService: SkyModalHostService,
-    private config: SkyModalConfiguration,
-    private elRef: ElementRef,
-    private windowRef: SkyWindowRefService,
-    private componentAdapter: SkyModalComponentAdapterService) { }
-
   public ngAfterViewInit() {
     skyModalUniqueIdentifier++;
     this.componentAdapter.handleWindowChange(this.elRef);

src/modules/tiles/tile-dashboard/tile-dashboard.service.spec.ts

@@ -200,11 +200,12 @@ describe('Tile dashboard service', () => {
       }
     );
 
-    /* tslint:disable-next-line:no-unused-variable */
-    let testDashboardService = new SkyTileDashboardService(
-      mockDragulaService,
-      mockMediaQueryService
-    );
+    (function () {
+      return new SkyTileDashboardService(
+        mockDragulaService,
+        mockMediaQueryService
+      );
+    }());
 
     expect(setOptionsSpy).toHaveBeenCalled();
   });