Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Fixed bug with svg images, IE11 #1190

Merged
merged 4 commits into from
Oct 16, 2017
Merged

Conversation

Blackbaud-SteveBrush
Copy link
Member

Addresses: #1130

@codecov-io
Copy link

codecov-io commented Oct 9, 2017

Codecov Report

Merging #1190 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1190   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         355     355           
  Lines        6622    6622           
  Branches      853     853           
======================================
  Hits         6622    6622

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97228eb...5239176. Read the comment docs.

@Blackbaud-BobbyEarl
Copy link

This does seem to fix the problem @Blackbaud-SteveBrush. Is it weird we're using a different format for those now?

@Blackbaud-SteveBrush
Copy link
Member Author

@Blackbaud-BobbyEarl The only difference is that I didn't base64 encode the svg's contents. I'm getting the source files from Steglin and will see if I can recompile them if the inconsistency isn't appropriate.

@Blackbaud-BobbyEarl
Copy link

If feasible, I would vote to have them continue to use the same format.

@Blackbaud-PaulCrowder Blackbaud-PaulCrowder merged commit 519b268 into master Oct 16, 2017
@Blackbaud-PaulCrowder Blackbaud-PaulCrowder deleted the fix-error-images-ie11 branch October 16, 2017 17:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants