This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Fixed file attachments component in IE11 #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackbaud-SteveBrush
requested review from
Blackbaud-BobbyEarl and
Blackbaud-PaulCrowder
| this.acceptedOver = true; | ||
| } | ||
|
|
||
| } else if (transfer.files) { |
There was a problem hiding this comment.
This condition gets called when the data transfer is not empty, but does not support items.
| if (dropEvent.dataTransfer && dropEvent.dataTransfer.files) { | ||
| if (this.verifyDropFiles(dropEvent.dataTransfer.items)) { | ||
| if (this.verifyDropFiles(dropEvent.dataTransfer.files)) { |
There was a problem hiding this comment.
Here's the final core change.
Codecov Report
@@ Coverage Diff @@
## master #1179 +/- ##
======================================
Coverage 100% 100%
======================================
Files 355 355
Lines 6590 6592 +2
Branches 842 844 +2
======================================
+ Hits 6590 6592 +2
Continue to review full report at Codecov.
|
Blackbaud-PaulCrowder
approved these changes
Oct 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #1131
(This branch also includes some code-style adjustments; tabs, etc. I'll denote the core changes via comments.)
The primary issue is that IE11 does not support
DataTransfer.items. I researched other libraries, and how they handle this, and they allow any file on thedragoverevent, but do the file-type checking ondrop. This pull request deals with this problem in the same way.https://developer.mozilla.org/en-US/docs/Web/API/DataTransfer/items#Browser_compatibility
https://caniuse.com/#feat=dragndrop