Add tiledBody option to modal component. #1039

Blackbaud-TomRamsey · 2017-09-01T13:20:30Z

blackbaud-sky-savage · 2017-09-01T13:42:30Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: cf7e129
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/270824812

(Please note that this is a fully automated comment.)

codecov-io · 2017-09-01T13:55:28Z

Codecov Report

Merging #1039 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1039   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         317     317           
  Lines        5976    5980    +4     
  Branches      759     759           
======================================
+ Hits         5976    5980    +4

Impacted Files	Coverage Δ
src/modules/modal/modal-configuration.ts	`100% <ø> (ø)`	⬆️
src/modules/modal/modal.component.ts	`100% <100%> (ø)`	⬆️
src/modules/modal/modal.service.ts	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b903dc...788fede. Read the comment docs.

blackbaud-sky-savage · 2017-09-01T14:23:05Z

Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: efa00e8
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/270838342

(Please note that this is a fully automated comment.)

blackbaud-sky-savage · 2017-09-01T19:09:37Z

Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: 51aac99
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/270945022

(Please note that this is a fully automated comment.)

blackbaud-sky-savage · 2017-09-05T15:32:59Z

Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: e9550bf
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/272095810

(Please note that this is a fully automated comment.)

Fixed typo of SkyModalConfigurationInterface and exporting in default…

Blackbaud-ToddRoberts

Looks good from the UX side

Blackbaud-SteveBrush

I'd feel better if we also had a visual test to represent the tiled body.

blackbaud-sky-savage · 2017-09-07T17:28:05Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: bae5229
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/272984624

(Please note that this is a fully automated comment.)

blackbaud-sky-savage · 2017-09-07T17:48:43Z

Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: 50bed43
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/272984649

(Please note that this is a fully automated comment.)

blackbaud-sky-savage · 2017-09-07T18:09:36Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 7aab722
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/272984999

(Please note that this is a fully automated comment.)

blackbaud-sky-savage · 2017-09-08T12:37:35Z

Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: bddaa91
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/273272496

(Please note that this is a fully automated comment.)

blackbaud-sky-savage · 2017-09-08T16:54:59Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 4e2b86c
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/273365218

(Please note that this is a fully automated comment.)

Blackbaud-SteveBrush · 2017-09-12T19:08:53Z

skyux-spa-visual-tests/src/app/modal/modal-tiled-demo.component.ts

+export class ModalTiledDemoComponent implements OnInit {
+  public title = 'Hello world';
+
+  public ngOnInit() {


Do you need to include ngOnInit for the test?

@Blackbaud-SteveBrush I was just mirroring the other tests -do you want me to remove it from all of the modal tests?

Huh, you're right. Don't worry about it, we can clean these up in a different PR.

Blackbaud-SteveBrush · 2017-09-12T19:09:08Z

skyux-spa-visual-tests/src/app/modal/modal-tiled-demo.component.html

@@ -0,0 +1,26 @@
+<sky-modal [tiledBody]=true>


[tiledBody]="true"

Blackbaud-SteveBrush · 2017-09-12T19:11:05Z

src/app/components/modal/index.html

+        defaultValue="false"
+        isOptional="true"
+    >
+      When set to true, the modal will be styled for use with sky-tile sections.


@blackbaud-johnly: Got any feedback on the docs portion?

I'd reword this to be consistent with other descriptions for Boolean properties: "Indicates whether to style the modal for use with sky-tile sections." Or more simply, "Indicates whether the modal uses tiles." (Formatting "sky-style" as a code snippet, and doing the same with "true" if we don't reword this.)

Also, I think it would be useful to flesh this out. Based on the description in the issue this addresses (#1038), I'd suggest a second sentence like: "When set to true, the modal's background switches to $sky-background-color-neutral-light, and tile headings are styled as subsection headings."

Blackbaud-SteveBrush · 2017-09-12T19:11:19Z

src/app/components/modal/modal-demo-tiled-form.component.html

@@ -0,0 +1,32 @@
+<sky-modal [tiledBody]=true>


[tiledBody]="true"

blackbaud-sky-savage · 2017-09-12T19:19:01Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 37eed29
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/274737559

(Please note that this is a fully automated comment.)

blackbaud-sky-savage · 2017-09-12T20:45:30Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 56cdba7
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/274759750

(Please note that this is a fully automated comment.)

@blackbaud-johnly

Visual test looks good. Waiting for @blackbaud-johnly review.

blackbaud-sky-savage · 2017-09-13T14:49:28Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 047d745
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/275063469

(Please note that this is a fully automated comment.)

blackbaud-sky-savage · 2017-09-13T15:14:48Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 317675f
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/275074412

(Please note that this is a fully automated comment.)

blackbaud-sky-savage · 2017-09-13T16:14:29Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: b0e0e34
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/275100996

(Please note that this is a fully automated comment.)

blackbaud-sky-savage · 2017-09-13T16:38:39Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 8de4041
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/275109390

(Please note that this is a fully automated comment.)

blackbaud-johnly · 2017-09-13T18:07:26Z

src/app/components/modal/modal-demo.component.html

-<button type="button" class="sky-btn sky-btn-secondary" (click)="openModal('fullScreenModal')">
- Open Full Screen modal
+<button type="button" class="sky-btn sky-btn-primary" (click)="openModal('fullScreenModal')">
+ Open full screen modal


"full-screen" should be hyphenated

…skyux2 into modal-tiled

blackbaud-sky-savage · 2017-09-13T18:57:33Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 0d069cf
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/275160881

(Please note that this is a fully automated comment.)

blackbaud-sky-savage · 2017-09-13T19:42:54Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 0b548f6
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/275176892

(Please note that this is a fully automated comment.)

blackbaud-sky-savage · 2017-09-13T21:38:58Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 0fae2cd
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/275210476

(Please note that this is a fully automated comment.)

blackbaud-sky-savage · 2017-09-14T17:18:44Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 00f555d
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/275551816

(Please note that this is a fully automated comment.)

blackbaud-sky-savage · 2017-09-14T20:34:07Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 4ae5422
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/275613102

(Please note that this is a fully automated comment.)

blackbaud-sky-savage · 2017-09-15T19:35:16Z

Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: 788fede
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/276018401

(Please note that this is a fully automated comment.)

Add tiledBody option to modal component.

cf7e129

Remove unused import

efa00e8

Update styles per design feedback. Add missing unit test.

51aac99

Blackbaud-ToddRoberts self-requested a review September 5, 2017 13:32

Blackbaud-SteveBrush self-assigned this Sep 5, 2017

Merge branch 'master' into modal-tiled

e9550bf

Merge pull request #1 from blackbaud/master

50db2a4

Fixed typo of SkyModalConfigurationInterface and exporting in default…

Blackbaud-ToddRoberts reviewed Sep 5, 2017

View reviewed changes

Blackbaud-SteveBrush previously requested changes Sep 7, 2017

View reviewed changes

Blackbaud-TomRamsey and others added 3 commits September 7, 2017 13:04

Add visual test.

50bed43

Remove fdescribe

bae5229

Merge branch 'master' into modal-tiled

7aab722

Merge branch 'master' into modal-tiled

bddaa91

Merge branch 'master' into modal-tiled

4e2b86c

Merge branch 'master' into modal-tiled

37eed29

Blackbaud-SteveBrush reviewed Sep 12, 2017

View reviewed changes

Merge branch 'master' into modal-tiled

047d745

Blackbaud-SteveBrush requested a review from blackbaud-johnly September 13, 2017 14:36

Merge branch 'master' into modal-tiled

317675f

Blackbaud-SteveBrush added 2 commits September 13, 2017 11:50

Merge branch 'master' into modal-tiled

b0e0e34

Merge branch 'master' into modal-tiled

8de4041

blackbaud-johnly reviewed Sep 13, 2017

View reviewed changes

Blackbaud-SteveBrush closed this Sep 13, 2017

Blackbaud-SteveBrush reopened this Sep 13, 2017

Blackbaud-TomRamsey added 2 commits September 13, 2017 14:28

Update documentation

ef8f444

Merge branch 'modal-tiled' of https://github.com/Blackbaud-TomRamsey/…

0d069cf

…skyux2 into modal-tiled

Merge branch 'master' into modal-tiled

0b548f6

Merge branch 'master' into modal-tiled

0fae2cd

Merge branch 'master' into modal-tiled

00f555d

Merge branch 'master' into modal-tiled

4ae5422

Merge branch 'master' into modal-tiled

788fede

Blackbaud-SteveBrush approved these changes Sep 15, 2017

View reviewed changes

Blackbaud-SteveBrush merged commit e8b41a0 into blackbaud:master Sep 15, 2017

Blackbaud-TomRamsey deleted the modal-tiled branch September 29, 2017 17:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tiledBody option to modal component. #1039

Add tiledBody option to modal component. #1039

Blackbaud-TomRamsey commented Sep 1, 2017

blackbaud-sky-savage commented Sep 1, 2017

codecov-io commented Sep 1, 2017 •

edited

Loading

blackbaud-sky-savage commented Sep 1, 2017

blackbaud-sky-savage commented Sep 1, 2017

blackbaud-sky-savage commented Sep 5, 2017

Blackbaud-ToddRoberts left a comment

Blackbaud-SteveBrush left a comment

blackbaud-sky-savage commented Sep 7, 2017

blackbaud-sky-savage commented Sep 7, 2017

blackbaud-sky-savage commented Sep 7, 2017

blackbaud-sky-savage commented Sep 8, 2017

blackbaud-sky-savage commented Sep 8, 2017

Blackbaud-SteveBrush Sep 12, 2017

Blackbaud-TomRamsey Sep 12, 2017

Blackbaud-SteveBrush Sep 13, 2017

Blackbaud-SteveBrush Sep 12, 2017

Blackbaud-SteveBrush Sep 12, 2017

blackbaud-johnly Sep 13, 2017 •

edited

Loading

Blackbaud-SteveBrush Sep 12, 2017

blackbaud-sky-savage commented Sep 12, 2017

blackbaud-sky-savage commented Sep 12, 2017

blackbaud-sky-savage commented Sep 13, 2017

blackbaud-sky-savage commented Sep 13, 2017

blackbaud-sky-savage commented Sep 13, 2017

blackbaud-sky-savage commented Sep 13, 2017

blackbaud-johnly Sep 13, 2017

blackbaud-sky-savage commented Sep 13, 2017

blackbaud-sky-savage commented Sep 13, 2017

blackbaud-sky-savage commented Sep 13, 2017

blackbaud-sky-savage commented Sep 14, 2017

blackbaud-sky-savage commented Sep 14, 2017

blackbaud-sky-savage commented Sep 15, 2017

Add tiledBody option to modal component. #1039

Add tiledBody option to modal component. #1039

Conversation

Blackbaud-TomRamsey commented Sep 1, 2017

blackbaud-sky-savage commented Sep 1, 2017

codecov-io commented Sep 1, 2017 • edited Loading

Codecov Report

blackbaud-sky-savage commented Sep 1, 2017

blackbaud-sky-savage commented Sep 1, 2017

blackbaud-sky-savage commented Sep 5, 2017

Blackbaud-ToddRoberts left a comment

Choose a reason for hiding this comment

Blackbaud-SteveBrush left a comment

Choose a reason for hiding this comment

blackbaud-sky-savage commented Sep 7, 2017

blackbaud-sky-savage commented Sep 7, 2017

blackbaud-sky-savage commented Sep 7, 2017

blackbaud-sky-savage commented Sep 8, 2017

blackbaud-sky-savage commented Sep 8, 2017

Blackbaud-SteveBrush Sep 12, 2017

Choose a reason for hiding this comment

Blackbaud-TomRamsey Sep 12, 2017

Choose a reason for hiding this comment

Blackbaud-SteveBrush Sep 13, 2017

Choose a reason for hiding this comment

Blackbaud-SteveBrush Sep 12, 2017

Choose a reason for hiding this comment

Blackbaud-SteveBrush Sep 12, 2017

Choose a reason for hiding this comment

blackbaud-johnly Sep 13, 2017 • edited Loading

Choose a reason for hiding this comment

Blackbaud-SteveBrush Sep 12, 2017

Choose a reason for hiding this comment

blackbaud-sky-savage commented Sep 12, 2017

blackbaud-sky-savage commented Sep 12, 2017

blackbaud-sky-savage commented Sep 13, 2017

blackbaud-sky-savage commented Sep 13, 2017

blackbaud-sky-savage commented Sep 13, 2017

blackbaud-sky-savage commented Sep 13, 2017

blackbaud-johnly Sep 13, 2017

Choose a reason for hiding this comment

blackbaud-sky-savage commented Sep 13, 2017

blackbaud-sky-savage commented Sep 13, 2017

blackbaud-sky-savage commented Sep 13, 2017

blackbaud-sky-savage commented Sep 14, 2017

blackbaud-sky-savage commented Sep 14, 2017

blackbaud-sky-savage commented Sep 15, 2017

codecov-io commented Sep 1, 2017 •

edited

Loading

blackbaud-johnly Sep 13, 2017 •

edited

Loading