Added event that fires when the search component's x is clicked #1013
Conversation
|
Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: dddb79b (Please note that this is a fully automated comment.) |
Codecov Report
@@ Coverage Diff @@
## master #1013 +/- ##
======================================
Coverage 100% 100%
======================================
Files 308 308
Lines 5592 5594 +2
Branches 704 704
======================================
+ Hits 5592 5594 +2
Continue to review full report at Codecov.
|
| @@ -73,6 +73,9 @@ export class SkySearchComponent implements OnDestroy, OnInit, OnChanges { | |||
| @Output() | |||
| public searchChange = new EventEmitter<string>(); | |||
|
|
|||
| @Output() | |||
| public searchClear = new EventEmitter(); | |||
There was a problem hiding this comment.
The EventEmitter type defaults to any, but the consumer is not expecting to receive anything in the event handlers. Mind adding EventEmitter<void>(); to make it more clear?
|
Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: dc5cfed (Please note that this is a fully automated comment.) |
|
Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: 614800e (Please note that this is a fully automated comment.) |
No description provided.