Fixing Accessibility Problems (#870)

* Ng4 upgrade (#799)

* Package upgrades

* Fixed tslint issues

TODO:
  - fix search and sort tests

* Update package.json

* Fix context replacement plugin

* Remove forkCheckerPlugin from webpack

* Fix contentBase error

* fix sort test add logging back to karma.conf

* Fix search tests

TODO:
  - fix code coverage gaps

* Fix lint errors

* ignore new istanbul quirks

* update rollup to include platform browser name

* Angular 4 Upgrade > Additional Edits (#702)

* Allow for proper nesting for getting data for lists and grids (#671)

* Changed the list helper getData function to set the result to null if the final part was undefined so that nesting works correctly.

* Added unit tests

* updates skyux2 docs to use stache2 (#681)

* home page and pulling in stache things

* removed need for title service

* components demo component using stache

* removed change to package json

* removed unecessary method

* updating learn page and removing overview folder

* spacing issue fixed

* Convert reference topics to Stache 2

* refactored all the tutorial section

* Doc tweaks for Stache 2.

* Final doc tweaks before merge

* versioned without vs

* Update builder version (#693)

* Update builder version

* Remove unneeded packages

* Update full page modal header sizes (#679)

* Update full page modal header sizes

* Update full screen modal screenshots

* Travis build 1313 pushed to skyux2 [ci skip]

* Update wait component z-index (#684)

* Travis build 1316 pushed to skyux2 [ci skip]

* Adjust padding for closeable tab (#685)

To account for built-in padding in the close button.

* Travis build 1318 pushed to skyux2 [ci skip]

* Handle styles for filedrop when links are not allowed (#686)

* Travis build 1325 pushed to skyux2 [ci skip]

* Add cancel button to wizard docs and update modal button spacing (#689)

* Added yarn lock

* Cleaned files based on lint rules

* Removed unused comments

* Updated excluded source maps

* Updated version of tslint

* Fixed linting errors

* Reverting version of browserstack-local

* Update to connect to browserstack properly

Use browserstack service instead of binary. Also fix error with axe.

* Fix variable name

* Bump tests

* Remove unit tests to test visual tests on their own

* Actually remove unit tests for ci to run visuals

* Use one parallel test

* Add error logs for wdio

* Add unit tests back

* Log build number for visual tests on ci

* Add logs to see what's going on

* Try to use travis browsersrtack addon

* try using travis browserstack again

* remove old browserstack stuff

* Use encrypted variables with travis browserstack

* Add more logging and use different travis encryption

* Add more logging

* Add more logging to webdriver

* Add more logging

* Tweak visual server settings

* try running visual test webpack dev server

* set noInfo to false

* update host for dev server

* use local browserstack wdio

* see what error occurs when using nonsense text

* Add env variables back

* Add more wdio configuration

* Use browserstack binary

* Remove extra options from visual-server

* Remove unneeded logging

* make log level silent

* Run entire test suite

Revert normalize-sass to original version

* use old wdio versions for testing

* Add connection retry settings

* whitespace bump

* Re update wdio packages

* Remove unneeded logging

* Remove parallel testing

* Use sudo required for builds

* remove reference to browserstack-local

* See how 25 parallel tests run

* Use 3 parallel visual tests and latest stable version of node

* Update visual-server.js

* Update travis-script.sh

* Updated formatting

* More adjustments

* Added console logs

* Added error checking

* Added logs

* Reduced number of instances

* Updated logs

* Updated log

* Updated logs

* Updates

* Removed console logs

* Changed styles for visual test

* Updated wait test

* Updates to private variables

* Updated list toolbar default

* Updated public variable

* Updating selenium version

* Fixed bugs with templates

* Cleaned up unnecessary changes

* Updated version of stache

* Upped max instances

* Up wait for timeout

* Add some waitForVisibles in alert and action button

* Added path resolves

* Builder visual (#791)

* Add start of visual tests

* continue working on skyux builder visual tests

* more work on getting builder visual tests to work

* More work around visual tests

* fix package name typo

* Update import paths for visual test spa

* Add normalize-scss to package.json

* Fix moment import to work with rollup

This way works also with copying the dist folder to node_modules

* fix tile strangeness

* start scripts for visual test setup

* Continue protractor work

* start of visual test command

* duplicate a bit of work to get protractor ready to go

* Get protractor to go to a page

* Add first pass at image comparison

TODO:
  - do not fail when image does not exist

* Continue pixdiff work

* Work on thresholds

* Screenshots working with alert visual test

TODO:
  - create compare screenshot wrapper function
  - get action button tests
  - get working with browserstack
  - get working with browserstack and TravisCI

* Add wrapper function for visual tests

TODO:
  - accessibility testing
  - more elegant way to change size
  - use browserstack
  - travis commands

* Add checkAccessibility

TODO:
  - browserstack configuration
  - get working in travis

* Break out local visual test conf file

* Add content for ci visual tests

TODO:
  - switch configuration file used based on argue
  - test using browserstack
  - add the rest of the tests
  - get TravisCI implementations working

* Allow visual tests to change config based on command line

* Browserstack tests working

* fix browserstack local visual tests

TODO:
  - get other tests moved over
  - test using browserstack
  - get TravisCI integration working
  - remove all traces of wdio and old tests

* Add avatar visual test

* Add button visual test

* Add visual tests for card, checkbox, and chevron

* Add datepicker, definition list, and dropdown visual tests

* Add error, file drop, and filter visual tests

* Add visual tests for grid, key-info, label, list-secondary-actions, list-view-checklist, and modals

* add visual tests for navbar

* Add page summary visual tests

* Add visual tests for paging, radio, repeater

* Add visual tests for search, sort, tabs

* Add visual tests for text-expand, text-expand-repeater, tiles

* Finsih visual tests

* Updated visual tests

* Update ci tests

* fix package.json conflict

* update other visual test scripts

* Tweak scripts

* Fix lint errors

* Attempt to add path for skyux/dist/core

* Updated stache version

* ignore temporary visual test files

* Update code coverage

* Remove some old visual tests

* Remove old visual test artifacts

* Remove other old visual test artifacts

* remove webdriver packages from package.json

* Update documentation for visual tests

* Finish documentation for new visual test methodology

* Fix visual test selector in new modal tests

* Updated version of Stache (#805)

* Updated version of stache

* Add tsconfig ignore for visual tests

* Hit release candidate branch

* Fix build errors

* Update baseline screenshots in travis scripts

* white space bump

* update travis scripts (#806)

* update travis scripts

* update visual baseline script

* Update visual baseline with logging (#807)

* Travis build 1644 pushed to skyux2 [ci skip]

* Changelog and package updates for rc.0 (#808)

* Merge 32 (#816)

* AppSettings and config files docs.

* appSettings and config files docs.

* Doc tweaks.

* Code sample cleanup

* Max height transition (#804)

* update builder version for skyux documentation

* pass string to expandmode

* Update container for component search

* Use class instead of inline styles

* work on text expand firefox bug

* continue work on firefox transitions

* Adjust text expand animation for firefox

* Update tests for new text expand animation

* Fix tslint errors

* Update master plunker to point to beta release (#812)

* List paging first page (#814)

* Only set page number on search when paging exists

* Add tests for search paging bug

* Updates for beta.32 (#815)

* Fix typo for iso8601

* Update dependencies for spa visual tests

* Updates for rc.1 (#817)

* Updates for rc.1

* Tweak changelog styles

* Update karma firefox (#818)

* Drop down primary (#819)

* added primary in html class

* testing for primary dropdown option

* lint errors fixed

* documentation fixes from john

* documentation changes

* changed isPrimary boolean property to buttonStyle string property

* fixed test errors

* Updated versions of Stache, Builder (#821)

* Updated version of stache

* Add tsconfig ignore for visual tests

* Hit release candidate branch

* Fix build errors

* Update baseline screenshots in travis scripts

* white space bump

* Update package.json

* Update package.json

* Update package.json

* Updated releases

* Updated version of stache

* Updated version of stache

* Added resolve for visual tests

* Updated version of stache

* Merging master branch, Release 2.0.0-beta.2 (#826)

* AppSettings and config files docs.

* appSettings and config files docs.

* Doc tweaks.

* Code sample cleanup

* Max height transition (#804)

* update builder version for skyux documentation

* pass string to expandmode

* Update container for component search

* Use class instead of inline styles

* work on text expand firefox bug

* continue work on firefox transitions

* Adjust text expand animation for firefox

* Update tests for new text expand animation

* Fix tslint errors

* Update master plunker to point to beta release (#812)

* List paging first page (#814)

* Only set page number on search when paging exists

* Add tests for search paging bug

* Updates for beta.32 (#815)

* Adding Autonumeric Pipe/Module (#792)

* Adding Autonumeric

* Fixed Test

* Changed name from SkyAutonumeric to  SkyNumeric

* Changing formatting

* Changes per comments, OptionsObject used

* Updated wording

* Email validation (#810)

* created email validation ts

* email validation scss

* email validation code and test start

* email validator testing files

* last lint error fixed

* component page summary

* error message/red halo doesn't show until lost focus

* Changes from Patrick

* Changes from Patrick (took care of errors)

* added form control for demo input box consistency

* Fixed lint errors

* Added sky-form-control to demo/removed onInit from module code

* Lint errors

* Add note about serving in Windows 10 with IE11 or Edge. (#820)

* Add note about serving in Windows 10 with IE11 or Edge.

* Rework note based on feedback from Bobby.

* Updates for beta.33 (#825)

* Fixed linting errors

* Update package.json

* Dont run skyux build for now

* Updated travis script

* Readded build

* Moved remove commands

* Updated version of builder

* Updated changelog and version

* Tab keyboard support (#843)

* Added animation polypill

* Moved import to dependencies

* Tab keyboard accessibility

* Added animation polyfill (#841)

* Added animation polypill

* Moved import to dependencies

* Text Highlight directive (#839)

* Adding highlight directive and demo page.

* Adding and replacing highlight style.

* Use mark element.

* Update demo.

* Add test for directive.

* Update test.

* Update highlighter to be case insensitive.

* Can't add mark text to innerhtml.

* Update tests.

* Use mutation observer for dom events.

* Reformat test

* Update async test.

* Mock mutation observer service.

* Add extra test.

* Adding visual tests.

* Add text highlight visual test.

* Move mutation service class.

* Update event creation in test.

* Adding test for mutation observer class. Removing undefined check for IE10.

* Disconnect mutation observer on destroy. Add exports. Fix name.

* Update angular to 4.2.5 (#850)

* AppSettings and config files docs.

* appSettings and config files docs.

* Doc tweaks.

* Code sample cleanup

* Max height transition (#804)

* update builder version for skyux documentation

* pass string to expandmode

* Update container for component search

* Use class instead of inline styles

* work on text expand firefox bug

* continue work on firefox transitions

* Adjust text expand animation for firefox

* Update tests for new text expand animation

* Fix tslint errors

* Update master plunker to point to beta release (#812)

* List paging first page (#814)

* Only set page number on search when paging exists

* Add tests for search paging bug

* Updates for beta.32 (#815)

* Adding Autonumeric Pipe/Module (#792)

* Adding Autonumeric

* Fixed Test

* Changed name from SkyAutonumeric to  SkyNumeric

* Changing formatting

* Changes per comments, OptionsObject used

* Updated wording

* Email validation (#810)

* created email validation ts

* email validation scss

* email validation code and test start

* email validator testing files

* last lint error fixed

* component page summary

* error message/red halo doesn't show until lost focus

* Changes from Patrick

* Changes from Patrick (took care of errors)

* added form control for demo input box consistency

* Fixed lint errors

* Added sky-form-control to demo/removed onInit from module code

* Lint errors

* Add note about serving in Windows 10 with IE11 or Edge. (#820)

* Add note about serving in Windows 10 with IE11 or Edge.

* Rework note based on feedback from Bobby.

* Updates for beta.33 (#825)

* Update link (#837)

* Fix timepicker demo (#847)

* Fix timepicker demo

* Remove unneeded whitespace

* Update angular to 4.2.5

Also update to latest version of state and skyux-builder

* Add ignore around branch

* Travis build 1744 pushed to skyux2 [ci skip]

* Updates for 2.0.0-rc.3 (#851)

* Updates for 2.0.0-rc.4 (#852)

* Update accessibility for context buttons on demo page. Fixing typo in list view checklist description.

* Update label text.

* Add default label to dropdown component.

* Add test for aria label.

* Fix merge conflict.

src/app/components/list-view-checklist/index.html

@@ -18,7 +18,7 @@
         defaultValue="label"
         isOptional="true"
     >
-      Specifies the name of the lebel field selector.
+      Specifies the name of the label field selector.
       Acceptable values: <code>string</code>.
     </sky-demo-page-property>
     <sky-demo-page-property

src/modules/dropdown/dropdown.component.spec.ts

@@ -104,6 +104,32 @@ describe('Dropdown component', () => {
 
       expect(dropdownMenu1).not.toBeVisible();
     });
+
+     it('should display default label when label not set', () => {
+
+      let fixture = TestBed.createComponent(DropdownParentTestComponent);
+      let el: HTMLElement = fixture.nativeElement;
+
+      fixture.detectChanges();
+
+      let button = el.querySelector('#dropdown-1 .sky-dropdown-button') as HTMLButtonElement;
+      let label = button.getAttribute('aria-label');
+
+      expect(label).toBe('Context menu');
+    });
+
+     it('should display default label when label is set', () => {
+
+      let fixture = TestBed.createComponent(DropdownParentTestComponent);
+      let el: HTMLElement = fixture.nativeElement;
+
+      fixture.detectChanges();
+
+      let button = el.querySelector('#dropdown-4 .sky-dropdown-button') as HTMLButtonElement;
+      let label = button.getAttribute('aria-label');
+
+      expect(label).toBe('test label');
+    });
   });
 
   describe('postition tests', () => {

src/modules/dropdown/dropdown.component.ts

@@ -9,6 +9,7 @@ import {
 import { SkyDropdownAdapterService } from './dropdown-adapter.service';
 
 import { SkyWindowRefService } from '../window';
+import { SkyResources } from '../resources';
 
 @Component({
   selector: 'sky-dropdown',
@@ -38,7 +39,13 @@ export class SkyDropdownComponent implements OnDestroy {
   }
 
   @Input()
-  public label: string;
+  public get label(): string{
+    return this._label || SkyResources.getString('context_menu_default_label');
+  }
+
+  public set label(value: string) {
+    this._label = value;
+  }
 
   @Input()
   public title: string;
@@ -65,6 +72,8 @@ export class SkyDropdownComponent implements OnDestroy {
 
   private _trigger: string;
 
+  private _label: string;
+
   constructor(
     private renderer: Renderer,
     private elRef: ElementRef,

src/modules/dropdown/fixtures/dropdown-parent.component.fixture.html

@@ -46,4 +46,19 @@
         </sky-dropdown-item>
       </sky-dropdown-menu>
     </sky-dropdown>
+</div>
+
+<div id="dropdown-4">
+  <sky-dropdown
+      buttonType="context-menu"
+      label="test label">
+      <sky-dropdown-button>
+        Show dropdown
+      </sky-dropdown-button>
+      <sky-dropdown-menu>
+        <sky-dropdown-item>
+          test
+        </sky-dropdown-item>
+      </sky-dropdown-menu>
+    </sky-dropdown>
 </div>