Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: folder icons in 'Open Profile Directory' in Floorp browser's application menu #762

Merged
merged 3 commits into from
Aug 26, 2023
Merged

Conversation

menndouyukkuri
Copy link
Contributor

Describe the PR
Fixed folder icons not showing up in 'Open Profile Directory' in Floorp browser's application menu.

PR Type

  • Add: Add feature or enhanced.
  • Fix: Bug fix or change default values.
  • Clean: Refactoring.
  • Doc: Update docs.

Screenshots
Current
スクリーンショット 2023-08-26 155225

Expected behavior
スクリーンショット 2023-08-26 155113

Additional context
I'm an amateur, so I may have missed some points to fix.

Copy link
Owner

@black7375 black7375 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for correcting my mistake.

@black7375 black7375 merged commit d20667b into black7375:master Aug 26, 2023
@black7375 black7375 added Class::Icon Icon for panels, menus, libraries Compenent::Panel Panel menu (not pop-up) Issue::Bug Something isn't working labels Aug 26, 2023
@black7375
Copy link
Owner

It's a small code, so I'm sure it works well.
If you want to contribute to a more complicated code, you may have difficulty modification multiple files.

Then the following document may be helpful !!
https://github.com/black7375/Firefox-UI-Fix/tree/master/docs#project-specific

Set the environment, and give the command yarn build.
The .scss file can be automatically converted to .css.

If you have difficulty contributing, please feel free to click the following link to explain.
I will help you as much as I know.
https://github.com/black7375/Firefox-UI-Fix/discussions/new?category=help-contribute-to-this-project

@menndouyukkuri
Copy link
Contributor Author

Thank you for your very kind reply.

black7375 added a commit that referenced this pull request Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class::Icon Icon for panels, menus, libraries Compenent::Panel Panel menu (not pop-up) Issue::Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants