Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Padding - Unified extensions panel with compact mode #721

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

ricewind012
Copy link
Contributor

Describe the PR
add compact mode support for the unified extensions panel

PR Type

  • Add: Add feature or enhanced.
  • Fix: Bug fix or change default values.
  • Clean: Refactoring.
  • Doc: Update docs.

Related Issue
#711

Screenshots

before:
before
after:
after

@Aleksandra0056
Copy link
Contributor

Thank you for implementing it, to be honest it was so large in comparison to other menus.

@ricewind012
Copy link
Contributor Author

translations panel next, then all the other ones

Copy link
Owner

@black7375 black7375 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You look fine. I'll merge it.


It's a just question.
What do you think about remove label(Can't read and change data on this site)?
For me, a hide of label didn't hinder my use.

@black7375 black7375 merged commit 4d84c16 into black7375:master Jun 14, 2023
@ricewind012
Copy link
Contributor Author

It's a just question. What do you think about remove label(Can't read and change data on this site)? For me, a hide of label didn't hinder my use.

it will be OK if you remove it only under compact mode
I'd like an option for an icon-only view, like this:
image
source:

#unified-extensions-area {
  flex-direction: row;
}
.unified-extensions-item-contents,
.unified-extensions-item-menu-button {
  display: none !important;
}

@black7375
Copy link
Owner

Thank you for answer. Then I will remove the label in compact mode.
For screens with only icons, I'll add it in the next major version!!!

@ricewind012 ricewind012 deleted the patch-1 branch June 18, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants