Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right click menu of Tree Style Tab no longer has separators - broken in FF116+ #758

Closed
2 of 9 tasks
MagicalDrizzle opened this issue Aug 23, 2023 · 5 comments
Closed
2 of 9 tasks
Labels
Browser::Upstream Changes or bugs from Firefox Class::Color Color, background, blur, etc. Component::Context-Menu Only for context menu Env::Windows Issues on Windows10, Windows11, unknown windows Issue::Bug Something isn't working

Comments

@MagicalDrizzle
Copy link
Contributor

Describe the bug

(FF116+)

  1. Install Tree Style Tab.
  2. Right click the vertical tab to bring up the menu.
  3. Separators no longer appears.

Expected behavior

(FF115-)
Separator appears.

Screenshots

116115

left is 116.0, right is 115.0.3

OS

Windows 10

OS - Others

No response

Firefox Version

v116.0

Distribution

Theme

Theme - More Info

No response

user.js setup

Unchanged from the user.js distributed with v8.0.0

Additional context

No response

@MagicalDrizzle MagicalDrizzle added the Issue::Bug Something isn't working label Aug 23, 2023
@black7375 black7375 added Env::Windows Issues on Windows10, Windows11, unknown windows Class::Color Color, background, blur, etc. Component::Context-Menu Only for context menu Browser::Upstream Changes or bugs from Firefox labels Aug 24, 2023
black7375 added a commit that referenced this issue Aug 25, 2023
TODO: All fullycolors must be rewritten in the long run.
(Sidebar Internal Content Isolated)
@black7375
Copy link
Owner

The confirmation has changed the structure so that the sidebar content is isolated.
First of all, I worked briefly on separator, but in the long run, there are things I need to work on again so that the color of the sidebar context menu works with the theme.

@AuRiMaS666
Copy link

This is probably related to this, so I'll just add to this thread, instead of opening a new one.

There's no separators at all when right clicking items in the Library window. And, as mentioned by the OP, Sidebar separator colors are not right, they're too dark to match the background. When right clicking items directly on the Bookmarks Toolbar or using the dropdown menu, everything is displayed correctly.

This is on Win11, Firefox v117, it was the same on v116 as well.

2023-08-29 11 22 26 2023-08-29 11 19 58

@black7375
Copy link
Owner

It was a smaller task than I thought.
Now it should work correctly.
Could you test it?

@AuRiMaS666
Copy link

Seems to work fine now, thanks!

2023-09-03 13 05 51 2023-09-03 13 06 59

@black7375
Copy link
Owner

@AuRiMaS666
Thank you for fast feedback!!

JohnyP36 added a commit to JohnyP36/UserChrome that referenced this issue Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Browser::Upstream Changes or bugs from Firefox Class::Color Color, background, blur, etc. Component::Context-Menu Only for context menu Env::Windows Issues on Windows10, Windows11, unknown windows Issue::Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants