Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padding between pinned and unpinned tabs is visible again #720

Closed
2 of 9 tasks
filips123 opened this issue Jun 10, 2023 · 2 comments
Closed
2 of 9 tasks

Padding between pinned and unpinned tabs is visible again #720

filips123 opened this issue Jun 10, 2023 · 2 comments
Labels
Browser::Upstream Changes or bugs from Firefox Class::Padding Padding and margin related layout Component::Tabbar Tab or tabbar Env::Windows Issues on Windows10, Windows11, unknown windows Issue::Bug Something isn't working Priority::High Solve and focus on it first

Comments

@filips123
Copy link
Contributor

Describe the bug

Since a few days on Nightly, padding between last pinned tab and the first unpinned one is again larger and more noticeable.

Expected behavior

Padding should be smaller/not noticeable, like it was before.

Screenshots

slika

OS

Windows 10

OS - Others

No response

Firefox Version

116.0a1 (20230609214634)

Distribution

Theme

Theme - More Info

No response

user.js setup

user.js setup
userChrome.compatibility.os	true	
userChrome.compatibility.theme	true	
userChrome.decoration.animate	true	
userChrome.decoration.cursor	true	
userChrome.decoration.download_panel	true	
userChrome.decoration.field_border	true	
userChrome.fullscreen.overlap	true	
userChrome.fullscreen.show_bookmarkbar	true	
userChrome.icon.context_menu	true	
userChrome.icon.global_menu	true	
userChrome.icon.global_menubar	true	
userChrome.icon.library	true	
userChrome.icon.menu	true	
userChrome.icon.panel	true	
userChrome.icon.panel_full	true	
userChrome.icon.panel_photon	false	
userChrome.icon.panel_sparse	false	
userChrome.padding.bookmark_menu	false	
userChrome.padding.bookmarkbar	false	
userChrome.padding.global_menubar	false	
userChrome.padding.infobar	true	
userChrome.padding.menu	false	
userChrome.padding.navbar_width	true	
userChrome.padding.panel	false	
userChrome.padding.popup_panel	true	
userChrome.padding.tabbar_height	true	
userChrome.padding.tabbar_width	true	
userChrome.padding.toolbar_button	true	
userChrome.padding.urlbar	false	
userChrome.rounding.square_tab	false	
userChrome.tab.bar_separator	false	
userChrome.tab.bottom_rounded_corner	false	
userChrome.tab.box_shadow	false	
userChrome.tab.close_button_at_hover	true	
userChrome.tab.color_like_toolbar	false	
userChrome.tab.connect_to_window	false	
userChrome.tab.container	true	
userChrome.tab.crashed	true	
userChrome.tab.dynamic_separator	true	
userChrome.tab.dynamic_separtor	true	
userChrome.tab.lepton_like_padding	false	
userChrome.tab.letters_cleary	true	
userChrome.tab.multi_selected	true	
userChrome.tab.newtab_button_like_tab	false	
userChrome.tab.newtab_button_proton	true	
userChrome.tab.newtab_button_smaller	false	
userChrome.tab.photon_like_contextline	false	
userChrome.tab.photon_like_padding	false	
userChrome.tab.pip	true	
userChrome.tab.sound_hide_label	true	
userChrome.tab.sound_with_favicons	true	
userChrome.tab.static_separator	false	
userChrome.tab.static_separator.selected_accent	false	
userChrome.tab.unloaded	true	
userChrome.tabbar.as_titlebar	false	
userChrome.theme.built_in_contrast	true	
userChrome.theme.fully_color	true	
userChrome.theme.fully_dark	true	
userChrome.theme.proton_chrome	true	
userChrome.theme.proton_color	true	
userChrome.theme.system_default	true

Additional context

This is probably because of a change in recent Firefox Nightly that replaced [first-visible-unpinned-tab] selector with :nth-child, so CSS does not match the correct tab anymore. So, everything that references first-visible-unpinned-tab needs to be changed to use :nth-child. There probably also needs to be some additional work to keep it compatible with current stable release which still uses the original selector.

@filips123 filips123 added the Issue::Bug Something isn't working label Jun 10, 2023
@black7375 black7375 added Env::Windows Issues on Windows10, Windows11, unknown windows Class::Padding Padding and margin related layout Component::Tabbar Tab or tabbar Priority::High Solve and focus on it first Browser::Upstream Changes or bugs from Firefox labels Jun 10, 2023
@black7375
Copy link
Owner

It hasn't been distributed in my nightly yet, so I'll test it and commit it after it's reproduced.

@black7375
Copy link
Owner

I applied a commit !! Thank you for the detailed report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Browser::Upstream Changes or bugs from Firefox Class::Padding Padding and margin related layout Component::Tabbar Tab or tabbar Env::Windows Issues on Windows10, Windows11, unknown windows Issue::Bug Something isn't working Priority::High Solve and focus on it first
Projects
None yet
Development

No branches or pull requests

2 participants