Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could Firefox UI FIX Support Floorp ? #710

Closed
surapunoyousei opened this issue Jun 2, 2023 · 19 comments
Closed

Could Firefox UI FIX Support Floorp ? #710

surapunoyousei opened this issue Jun 2, 2023 · 19 comments
Labels
Issue::Code Code quality and project structure, etc Issue::Enhancement New feature or request

Comments

@surapunoyousei
Copy link
Contributor

Is your feature request related to a problem?

Floorp's code is proprietary, and some codes are missing, so Floorp makes additions and adjustments.

The solution I'd like

I don't want to force you to do this, but I would appreciate it if you could add the specific code.

My solution would be to create CSS that loads when Floorp-specific settings are enabled.

Screenshots or video

image

Alternatives I've considered

Modify by Floorp's developer

Additional context

No response

@surapunoyousei surapunoyousei added the Issue::Enhancement New feature or request label Jun 2, 2023
@black7375 black7375 added the Issue::Code Code quality and project structure, etc label Jun 3, 2023
@black7375
Copy link
Owner

Can I see what code it is?
I think it can be supported if it doesn't cause side effects to Firefox.

Even if there is a side effect, there is a way.
As far as I know, waterfox has its own media query.
If you have a media query or a unique about:config value that runs only on Floorp, you can show it correctly.

@surapunoyousei
Copy link
Contributor Author

surapunoyousei commented Jun 5, 2023

  #usercssloader-menu {
    --menuitem-image: url("chrome://browser/skin/lepton/developer.svg");
  }
  #rebootappmenu {
    list-style-image: url("chrome://browser/skin/lepton/refresh-cw.svg");
  }
  #openprofiledir {
    list-style-image: url("chrome://browser/skin/lepton/folder.svg");
  }

We need this CSS

Floorp has its own status bar implemented by Floorp, but without icons. Because I don't have the technology to create icons, which is embarrassing.

@black7375
Copy link
Owner

black7375 commented Jun 5, 2023

Of course.
This project also provides icons of waterfox or tor browser.

I'll add the above code tomorrow.


For the icons, I've added them from the following sources.
(Although they are modified and used in size and color)

@surapunoyousei
Copy link
Contributor Author

Thank you.

@surapunoyousei
Copy link
Contributor Author

Floorp 11 has a native implementation of vertical tabs. Please let me know if there is anything you don't like about the design. Rework with respect to Firefox UI Fix

@black7375
Copy link
Owner

Added support for Floorp.
Where can I try Floorp 11?

@surapunoyousei
Copy link
Contributor Author

@black7375
Copy link
Owner

black7375 commented Jun 17, 2023

Feedback

Workspace and Vertical tabbar are very cool !!
Browser content rounding looks like Edge and Arc browser, is also impressive.

Here are some feedback:

1. Vertical tabbar supports

There is a problem with the bottom round of the tab, so I added a code for compatibility. 3058069

2. Sidebar

Firefox's sidebar feature was not available.

I'am try to these addons:

3. Button background color

The background color of the button is too dark when the system default theme.

image

4. Extension page

I think it would be consistent if the side menu had a bar like General in the settings.

image
image

5. Panel Setting

If you set userChrome.icon.full to true, set userChrome.icon.panel_photon to false.
If both are true, problems may occur in some layouts.

https://github.com/surapunoyousei/Floorp/blob/3da07d5fe6715309b1f40c899d4e8db146f07968/floorp/browser/app/profile/000-floorp.js#L345

6. Workspace Name

Putting the space seems to have a problem.

@surapunoyousei
Copy link
Contributor Author

surapunoyousei commented Jun 17, 2023

I see. I use Dark mode. I didn't test it. we are sry.

  1. Vertical tabbar supports:

Thanks !

  1. Sidebar

If you use verticaltabbar, Cannot use sidepanel addons.

  1. Extension page

I will add it.

  1. Panel Setting

I will change default preferences.

  1. Workspace Name

" " is disabled because they could cause elements to be generated. I will reconsider.

@surapunoyousei
Copy link
Contributor Author

I've identified a few issues and will work to fix them!

Thank you for your feedback.

@black7375
Copy link
Owner

black7375 commented Jun 17, 2023

I'm really enjoying the experience, great project!
Please tell me if you need anything in this project.

surapunoyousei added a commit to Floorp-Projects/Floorp that referenced this issue Jun 17, 2023
surapunoyousei added a commit to Floorp-Projects/Floorp that referenced this issue Jun 17, 2023
@surapunoyousei
Copy link
Contributor Author

Fixed !

@black7375
Copy link
Owner

Quick commit!! Thanks.

@surapunoyousei
Copy link
Contributor Author

surapunoyousei commented Jun 19, 2023

Thank you for v7.4.0 Release, I will replace Floorp's file.

@Illusive-Girl
Copy link

Floorp's code is proprietary

I thought Floorp free and opensource isn't it?

@black7375
Copy link
Owner

@Illusiveman931 Yes. floorp browser is opensource.
https://github.com/Floorp-Projects/Floorp

@Illusive-Girl
Copy link

you are right but I just don't understand why the main developer of floorp made this confusing statement

@black7375
Copy link
Owner

In the past, Lepton had some problems because it did not consider compatibility and icons for floorp.

We are now well supported through cooperation with the floorp maintainer.

@Illusive-Girl
Copy link

thanks for the answer, even if it doesn’t explain surapunoyousei’s statement, I guess it's not that important, sorry for disturbing you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue::Code Code quality and project structure, etc Issue::Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants