Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Add square corners support for the PDF viewer buttons #638

Closed
Aleksandra0056 opened this issue Feb 17, 2023 · 2 comments · Fixed by #644
Closed

Feature request: Add square corners support for the PDF viewer buttons #638

Aleksandra0056 opened this issue Feb 17, 2023 · 2 comments · Fixed by #644
Labels
Class::Rounding Element's rounding Issue::Enhancement New feature or request

Comments

@Aleksandra0056
Copy link
Contributor

Aleksandra0056 commented Feb 17, 2023 •
edited
Loading

Is your feature request related to a problem?

Buttons in PDF reader like: “Toggle sidebar”, “Show thumbnails”, “Show document outline”, “Find current outline item”, “Show attachments”, “Show layers”, “Previous page”, “Next page”, “Zoom out”, “Zoom in”, “Print”, “Save”, “Text”, “Draw” and “Tools” are unaffected by the square corners settings.

The solution I'd like

The mentioned buttons should be affected by the userChrome.rounding.square_button (They should have support for square corners).

Screenshots or video

No response

Alternatives I've considered

No response

Additional context

No response
@Aleksandra0056 Aleksandra0056 added the Issue::Enhancement New feature or request label Feb 17, 2023
@Aleksandra0056 Aleksandra0056 changed the title Feature request: Add square corners support for PDF viewer buttons Feature request: Add square corners support for the PDF viewer buttons Feb 17, 2023
ricewind012 added a commit to ricewind012/Firefox-UI-Fix that referenced this issue Feb 18, 2023
@ricewind012
Fix: Rounding - Missing chrome elements
9ed67a0 
Fixes black7375#636, black7375#637, black7375#638, black7375#639
@ricewind012 ricewind012 mentioned this issue Feb 18, 2023
Merged
4 tasks
@black7375 black7375 added the Class::Rounding Element's rounding label Feb 19, 2023
@Aleksandra0056
Copy link
Contributor Author

The PDF viewer buttons are still rounded, can you reopen this?

@Aleksandra0056
Copy link
Contributor Author

Aleksandra0056 commented Feb 21, 2023 •
edited
Loading

So, I'm decided to rather create a new issue, just ignore my comment above that was written one hour ago.

@Aleksandra0056 Aleksandra0056 mentioned this issue Feb 21, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Class::Rounding Element's rounding Issue::Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Some more fixes ricewind012/Firefox-UI-Fix
2 participants
@black7375 @Aleksandra0056