Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows10 Native menu layout #541

Closed
iansquenet opened this issue Dec 19, 2022 · 5 comments
Closed

Windows10 Native menu layout #541

iansquenet opened this issue Dec 19, 2022 · 5 comments
Labels
Class::Padding Padding and margin related layout Component::Context-Menu Only for context menu Distribution::Photon-Style Photon style distribution related Env::Windows Issues on Windows10, Windows11, unknown windows Issue::Bug Something isn't working

Comments

@iansquenet
Copy link

iansquenet commented Dec 19, 2022 •
edited
Loading

The tabs seems to be okay-ish, although inactive ones are not lit up. Also the context menu is completely unchanged (as noted on the last screenshot).

What I tried doing:

  • Manual installation
  • Powershell script installation

Operating System: Windows 10 Pro, version 22H2

image
image
@black7375
Copy link
Owner

Also the menus are unchanged.

What do you mean?

@black7375 black7375 added Issue::Bug Something isn't working Env::Windows Issues on Windows10, Windows11, unknown windows Component::Context-Menu Only for context menu Distribution::Photon-Style Photon style distribution related labels Dec 19, 2022
black7375 added a commit that referenced this issue Dec 19, 2022
@black7375
Doc: Issue - Blank issue disabled
40ecb8e 
Recently, bug reports are often done without inserting information. #528 #532 #539 #541
In this case, it is too difficult to reproduce.

Even if it's inconvenient, I think we need some restrictions.
@black7375
Copy link
Owner

Little more cleary, what kind of changes do you expect?
The image above matches the context menu I want.

@iansquenet
Copy link
Author

iansquenet commented Dec 19, 2022 •
edited
Loading

Little more cleary, what kind of changes do you expect? The image above matches the context menu I want.

This is the look I wanted to go for, which didn't work. Basically changing to Photon-style and expected the context and application menu to change accordingly. Sorry for not being great at explaining.
image

@black7375 black7375 added the Class::Padding Padding and margin related layout label Dec 19, 2022
@black7375
Copy link
Owner

black7375 commented Dec 19, 2022 •
edited
Loading

Ok, It is possible by setting browser.display.windows.non_native_menus to 0.

https://github.com/mozilla/gecko-dev/blob/516dbdf21e2e0aafe702400d632ee17f0375d361/modules/libpref/init/StaticPrefList.yaml#L1139-L1147

But there is a bug because it was made without considering native menu.

Original Native menu
image

Bugged
image

This issue will handle bugs and create an issue for new feature.

@black7375 black7375 mentioned this issue Dec 20, 2022
Open
@black7375 black7375 changed the title Photon-style not fully working on Firefox 108.0.1 Windows10 Native menu layout Dec 20, 2022
black7375 added a commit that referenced this issue Dec 20, 2022
@black7375
Fix: Icons - Windows10 Native Menu #541
528ab89
black7375 added a commit that referenced this issue Dec 20, 2022
@black7375
Fix: Icons - Windows10 Native Menu #541
80ab22a
black7375 added a commit that referenced this issue Dec 20, 2022
@black7375
Fix: Icons - Windows10 Native Menu #541
742075c
@black7375
Copy link
Owner

Now, will be works
image

black7375 added a commit that referenced this issue Dec 28, 2022
@black7375
Fix: Compatibility - Win10 nativemenu at bookmarkmenu #541
b91f923
black7375 added a commit that referenced this issue Dec 29, 2022
@black7375
Fix: Compatibility - Win10 nativemenu at bookmarkmenu #541
9035429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Class::Padding Padding and margin related layout Component::Context-Menu Only for context menu Distribution::Photon-Style Photon style distribution related Env::Windows Issues on Windows10, Windows11, unknown windows Issue::Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@black7375 @iansquenet