Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Large gray line separating the tab from the tab bar #499

Closed
4 of 13 tasks
tormater-yak opened this issue Oct 30, 2022 · 4 comments
Closed
4 of 13 tasks

Large gray line separating the tab from the tab bar #499

tormater-yak opened this issue Oct 30, 2022 · 4 comments
Labels
Class::Layout-Others Layout issues except Padding and Size issues Component::Tabbar Tab or tabbar Env::Linux Issues on Linux Issue::Bug Something isn't working

Comments

@tormater-yak
Copy link

tormater-yak commented Oct 30, 2022 •
edited
Loading

Describe the bug
Large gray line separating the tab from the tab bar

Expected behavior
Tabs should be connected to the tab bar

Screenshots
Ambiance: image
Light: image

Environment:

user.js setup
// Your settings

Additional context
Occurs on any theme I select, except Dark
@tormater-yak tormater-yak added the Issue::Bug Something isn't working label Oct 30, 2022
@tormater-yak
Copy link
Author

I'd also like to note that this only occurs while my GTK theme is set to Ambiance.

@black7375 black7375 added Env::Linux Issues on Linux Component::Tabbar Tab or tabbar Class::Layout-Others Layout issues except Padding and Size issues labels Oct 31, 2022
black7375 added a commit that referenced this issue Nov 1, 2022
@black7375
Fix: Tab Bar - Connected at Ambiance theme #499
ebef220
@black7375
Copy link
Owner

black7375 commented Nov 1, 2022 •
edited
Loading

Investigation Report

Environment

  • OS: Ubuntu 22.04.1 LTS x86_64

Yaru
image

Adwaita
image

Ambiance [REPRODUCE]
image

Ambiance - Bundle light [REPRODUCE]
image

Ambiance - Bundle Alpenglow [REPRODUCE]
image

Ambiance - Bundle Dark
image

It is a problem that only occurs in Ambiance's bright themes.

After patch

Now I see it as normal.
image

The size of titlebar buttons is not controlled, but it cannot be adjusted because of appearance: auto.
image

@tormater-yak Would you like to test?

@tormater-yak
Copy link
Author

image
After updating, the gray line is gone.

@black7375
Copy link
Owner

black7375 commented Nov 1, 2022 •
edited
Loading

Thanks for fast test 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Class::Layout-Others Layout issues except Padding and Size issues Component::Tabbar Tab or tabbar Env::Linux Issues on Linux Issue::Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@black7375 @tormater-yak