Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release zips contain unneeded files #467

Closed
Roy-Orbison opened this issue Sep 14, 2022 · 4 comments
Closed

Release zips contain unneeded files #467

Roy-Orbison opened this issue Sep 14, 2022 · 4 comments
Labels
Issue::Enhancement New feature or request

Comments

@Roy-Orbison
Copy link
Contributor

Is your feature request related to a problem?
It isn't very user-friendly to fill the release archives with the files that are only relevant to development, etc. Github's automatic zips of each release (labelled Source code) already contain these files. Does Firefox need __tests__/, yarn.lock or package.json for your modifications to work?

The solution I'd like
For the archives to contain only the minimum required files, maybe plus the readme and licence.

Alternatives I've considered
.gittributes, but the presence of the readme in the release (when it's ignored in your attributes file) leads me to believe they're not generated using git archive.

@black7375
Copy link
Owner

That's a good suggestion.

From the next time, the release does not include files related to development, and the license files(CREDITS, LICENSE) have been placed in the root to make them clearer.

@black7375
Copy link
Owner

Try to new release!!

@Roy-Orbison
Copy link
Contributor Author

Much better! Thank you. I notice the Waterfox file is gone, too, was that intentional?

@black7375
Copy link
Owner

Yes, That's only necessary for development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue::Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants