Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing icons in the menu #412

Closed
3 of 9 tasks
ghost opened this issue Jun 11, 2022 · 9 comments
Closed
3 of 9 tasks

Missing icons in the menu #412

ghost opened this issue Jun 11, 2022 · 9 comments
Labels
Class::Icon Icon for panels, menus, libraries Component::Context-Menu Only for context menu Env::Windows Issues on Windows10, Windows11, unknown windows Issue::Enhancement New feature or request Issue::Help-Wanted Extra attention is needed

Comments

@ghost
Copy link

ghost commented Jun 11, 2022 •
edited by black7375
Loading

Describe the bug
The share and select multiple tabs icons are not there.

Environment:

Screenshots

Screenshot (1)

Capture
@ghost ghost added the Issue::Bug Something isn't working label Jun 11, 2022
@black7375 black7375 added Env::Windows Issues on Windows10, Windows11, unknown windows Class::Icon Icon for panels, menus, libraries Component::Context-Menu Only for context menu labels Jun 13, 2022
black7375 added a commit that referenced this issue Jun 16, 2022
@black7375
Add: Option - tab contextmenu's share icon #412
bb9ecd6
@black7375 black7375 added Issue::Enhancement New feature or request and removed Issue::Bug Something isn't working labels Jun 22, 2022
@black7375 black7375 changed the title Missing icons in the tab menu Missing icons in the menu Jun 29, 2022
@black7375 black7375 mentioned this issue Jun 29, 2022
Closed
9 tasks
@w4t3r1ily
Copy link

I couldn't find the appropriate icon for Past and Go and Close Multiple Tabs. 😢

Share could be the generic share icon https://www.iconfinder.com/icons/352893/share_icon

Close multiple tabs an X in a circle

Redo a mirrored Undo

Paste and go like a Paste with an arrow?

@black7375
Copy link
Owner

share and redo already exist.

I'm not a designer, but only a very minimal icon custom.
(It is necessary to contribute to designers who can make custom icons.)

Target of icons

  • Close Multiple Tabs
  • Paste & Go
  • Paste & Search

@black7375 black7375 added the Issue::Help-Wanted Extra attention is needed label Jun 29, 2022
@ghost
Copy link
Author

ghost commented Sep 24, 2022

Any update on these?

@black7375
Copy link
Owner

Close Multiple Tabs is going to use Filter dismiss or Table dismiss.
However, Paste & Go and Paste & Search need the contribution.

black7375 added a commit that referenced this issue Oct 15, 2022
@black7375
Fix: Icons - Missing fully mode #412
6834545
@black7375
Copy link
Owner

black7375 commented Oct 15, 2022 •
edited
Loading

You can now use full icon with userChrome.icon.menu.full to true.
I've learned inkscape and made icons.

image
image
image

black7375 added a commit that referenced this issue Oct 15, 2022
@black7375
Fix: Icons - Missing fully mode #412
a55db38
@w4t3r1ily
Copy link

You can now use full icon with userChrome.icon.menu.full to true. I've learned inkscape and made icons.

And where do I find that?

@black7375
Copy link
Owner

  1. Install From Latest Code or From Git (Click).
  2. Set userChrome.icon.menu.full to true && restart

@w4t3r1ily
Copy link

  1. Install From Latest Code or From Git (Click).

    1. Set userChrome.icon.menu.full to true && restart

I have done that but the icons are still issing.

@black7375
Copy link
Owner

@udontkn0wme
You may have used the release file.
Required the latest commit, as reflected in v6.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Class::Icon Icon for panels, menus, libraries Component::Context-Menu Only for context menu Env::Windows Issues on Windows10, Windows11, unknown windows Issue::Enhancement New feature or request Issue::Help-Wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@black7375 @w4t3r1ily