Remove gap between pinned and unpinned tabs

[rodrigopedra]

First of all thanks for this repo. I totally agree with the pro/cons about proton on README.

I added this to my local copy:

  #tabbrowser-tabs[haspinnedtabs]:not([positionpinnedtabs]) > #tabbrowser-arrowscrollbox > .tabbrowser-tab[first-visible-unpinned-tab] {
    margin-inline-start: 0 !important;
  }

It removes the gap between pinned and unpinned tabs. Add it to the repo if you think it is a good addition.

Also, as I use a light theme I needed to tweak line 115 and change the color to var(--tabs-border-color) to get tab separators showing. I am not using any additional theme on Firefox, but with the previous value the tab separators won't show.

    background-color: var(--tabs-border-color) !important;

Thanks again and have a nice day.

[black7375]

I was hesitant because it seemed like a deliberate addition to the gap from Proton team.
I'm sure compact is, but the rest are still thinking.

A few hours ago, I made an update on the divider line. Would you like to check it?

[rodrigopedra]

I started using just before opening issue. Even though I ran a diff and besides my modifications outlined above I am running the last version.

Here are some screenshots:

Original from repo, no modifications

With only border color modification

With both border color and tab gap modifications

One thing to correct from my first post: line to be modified to use var(--tabs-border-color) should be line 113, not line 115 as I first stated. Reason I had an offset is that I added a comment on the top of my userChrome.css to keep a reference to this repo's URL.

If I can provide any other info, let me know.

[rodrigopedra]

Here is the diff between the original file and my custom file:

[black7375]

Nice report!!😎
I'm lying down to sleep now, so I'll fix it in the morning.

Thank you

[rodrigopedra]

You’re welcome! No rush on this, take your time and sleep tight.

Thanks again for the nice solution

[black7375]

Remove Gaps

First of all, I made it active in compact mode.
fa74a2b

Seperator Test

Extensive testing was done for the unselected tab's seperator.
Current Version

• Proton Light Theme
• Proton Dark Theme
• Firefox Alpenglow [Light]
• Firefox Alpenglow [Dark]
• System Default [Light]
• System Default [Dark]

Suggestion Version

• Proton Light Theme
• Proton Dark Theme
• Firefox Alpenglow [Light]
• Firefox Alpenglow [Dark]
• System Default [Light]
• System Default [Dark]

More GTK Themes

• Adwaita
• Adwaita-dark
• Breath[Screenshot's light system Theme]
• Breath-Dark[Screenshot's dark system Theme]
• Default
• Emacs
• HighContrast

Result

It was --toolbarseparator-color that looked consistently well. (Current Version).
But I'v been certainly knew that some themes (including GTK) may not be visible.

Therefore, we have created a new wiki document dealing with compatibility issues!!
https://github.com/black7375/Firefox-UI-Fix/wiki/Compatibility-Issues-Solution

[rodrigopedra]

Thanks for the wiki entry.

I had to keep --tabs-border-color in order to have the borders visible.

One thing to correct, although I am using KDE Plasma 5.21 with stock Breeze Twilight theme (from your screenshots it seems you are running KDE Plasma as well), I am using a custom color scheme called Ambiance-ISH (link below)

https://store.kde.org/p/1001434

Of course as this is a custom color scheme, I don't expect it to be handled by the original userChrome.css file provided here.

Totally forgot to mention it before, sorry. I use this color theme for so long I usually forget about it.

Also I kept the gap removal from my first comment, but also understand your reasoning around it. But maybe you could add it to the week to those who might want to remove it.

Thanks for all the help and the hard work to provide this custom CSS.

[black7375]

I will add an issue template that asks about the theme in use.

+ Good News
I think we'll fix the icon problem around next week. #2 (comment)

[black7375]

Actually, I hesitated because of the compatibility issues of tab separators and only provided it in the compact.

I now believe that a lot has been resolved, so we will remove the gap.
Thanks.